Lite terminal - default workspace folder

[Patresko]

Hello,

Is there any option how to set default workspace folder to do not pick every time when I want to open lite terminal in VS code?

[isc-bsaviano]

Hi @Patresko, in the past it would use the server connection for the active text editor by default, but this was removed because it was confusing some users. I see the value in saving the click, but I also think that requiring the click helps avoid confusion. I'll leave this open to see if anyone else wants to weigh in.

[Patresko]

I guess would be nice if there will be option for whose want to use default server connection in active editor and whose does not, they can select workspace folder.

But I see when I open via command pallet, then is open directly without choosing from where to get server connection. But from terminal tab, I need to prompt.

[gjsjohnmurray]

@isc-bsaviano do we dedup the entries and only make the user choose when their namespace connects to more than one server:namespace? And in that case maybe the choice would be better presented in terms of server:namespace than root folder name?

[isc-bsaviano]

@Patresko Yes, the command in the palette will use the active text editor's connection because that's a common pattern. The same behavior from the terminal was confusing users, so I changed that.

@gjsjohnmurray I don't think so.

[Patresko]

@isc-bsaviano Is not possible to just add option for the plugin if you want to use same connection information for both of terminals ? By the default can be turn off, but users like me can always check to override default behaviour.

Like I have mapped 3 different servers in 3 different workspace, so for me its not confusing on which server currently Im working and clicking to confirm connection for terminal is quiet annoying for me.

[isc-bsaviano]

@Patresko If I added a configuration setting every time someone disagreed with a UX decision we'd have a hundred of them. I don't think this single extra click is that bad of a price to pay for clarity. This is in line with how other terminals operate in multi-root workspace. For example, if I try to open a new zsh shell on my Mac from that terminal menu, it will ask me to pick a workspace folder to use as the current working directory. This is also still faster than typing iris terminal <instance> from a standard OS terminal.

[Patresko]

Yes I understood if this is for multi-root workspace, but if you have single workspace within one server its annoying to confirm all the time. Like you said before it was default option at the begening and for some confused users was changed.

So maybe stupid question, but there were more confused user than user whose were happy how does it worked before?

In my mac does not asking me even If im trying to open zsh. Because I do not have multi root workspace. I click zsh and terminal is directly loaded.

[isc-bsaviano]

@Patresko Can you send me your workspace definition please? If you only have one workspace folder then the extension shouldn't be asking you to choose.

[Patresko]

Sorry, I said it wrong, I have multiple folders but within same server.

"folders": [ { "name": "Classes", "uri": "isfs://intranet-be:intranet/?filter=*.cls" }, { "name": "Routines", "uri": "isfs://intranet-be:intranet/?filter=*.mac" }, { "name": "CSP Files", "uri": "isfs://intranet-be:intranet/?csp" } ],

[isc-bsaviano]

Thanks for clarifying that. I agree with @gjsjohnmurray that it would be a good enhancement to change the picker from "workspace folders" to "current server connections". Since you only have one, you wouldn't be prompted. I will take this on as an enhancement.

[isc-bsaviano]

I will tackle this after #1401 is merged.