Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download tokenizer artifacts in CI instead of storing them in tests/testdata/models #384

Open
khaledsulayman opened this issue Nov 14, 2024 · 0 comments
Open

Download tokenizer artifacts in CI instead of storing them in tests/testdata/models #384

khaledsulayman opened this issue Nov 14, 2024 · 0 comments
Labels
testing Relates to testing

Comments

@khaledsulayman
Copy link
Member

It was raised in discussion on #364 that we shouldn't be storing tokenizer artifacts in our testdata.

Points in favor

  • artifacts may become out-of-date overtime, leading to inaccurate tests
  • we should avoid adding an unnecessary amount of data to our codebase

Proposed solution

We download the necessary artifacts during CI runs in order to run tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Relates to testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khaledsulayman