Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option BootfileParam #340

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Add option BootfileParam #340

merged 2 commits into from
Dec 12, 2019

Conversation

xaionaro
Copy link
Contributor

See RFC5970 section 3.2.

  • Added support of option OptBootFileParam
  • Added BootfileParam to netboot results

@xaionaro xaionaro mentioned this pull request Dec 10, 2019
Merged
@codecov
Copy link

codecov bot commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #340 into master will increase coverage by 0.02%.
The diff coverage is 27.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   71.93%   71.95%   +0.02%     
==========================================
  Files          78       79       +1     
  Lines        3951     3969      +18     
==========================================
+ Hits         2842     2856      +14     
- Misses        952      954       +2     
- Partials      157      159       +2
Impacted Files Coverage Δ
dhcpv6/client6/client.go 3.2% <ø> (ø) ⬆️
netboot/netboot.go 0% <0%> (ø) ⬆️
dhcpv6/options.go 75.43% <100%> (+0.43%) ⬆️
dhcpv6/option_bootfileparam.go 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3997b8a...ab246f0. Read the comment docs.

@pmazzini pmazzini self-requested a review December 10, 2019 15:36
@xaionaro xaionaro force-pushed the master branch 2 times, most recently from d3c76be to b816906 Compare December 10, 2019 16:38
Natolumin
Natolumin reviewed Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@Natolumin Natolumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in netboot/ should probably be a separate commit, if not a separate PR. I haven't looked at them yet as I don't really know that code

dhcpv6/option_bootfileparam.go Outdated Show resolved Hide resolved
dhcpv6/option_bootfileparam.go Outdated Show resolved Hide resolved
dhcpv6/client6/client.go Show resolved Hide resolved
dhcpv6/option_bootfileparam.go Show resolved Hide resolved
dhcpv6/option_bootfileparam_test.go Show resolved Hide resolved
dhcpv6/option_bootfileparam_test.go Outdated Show resolved Hide resolved
hugelgupf
hugelgupf reviewed Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@hugelgupf hugelgupf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uio for the option parsing, like other options do

@xaionaro
Copy link
Contributor Author

xaionaro commented Dec 10, 2019 •
edited
Loading

The changes in netboot/ should probably be a separate commit, if not a separate PR. I haven't looked at them yet as I don't really know that code

I'll make a separate commit if this way is good enough :)

@xaionaro xaionaro requested a review from hugelgupf December 11, 2019 13:41
pmazzini
pmazzini previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Collaborator

@pmazzini pmazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me. I am not merging it yet to let other people comment.

Natolumin
Natolumin reviewed Dec 11, 2019
View reviewed changes
Copy link
Collaborator

@Natolumin Natolumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just comments and questions for clarification, except for the issue about panic which I think is important as it greatly changes the API of the library, and needs to be properly discussed

dhcpv6/option_bootfileparam.go Outdated Show resolved Hide resolved
dhcpv6/option_bootfileparam_test.go Show resolved Hide resolved
dhcpv6/option_bootfileparam.go Outdated Show resolved Hide resolved
dhcpv6/option_bootfileparam.go Outdated Show resolved Hide resolved
dhcpv6/option_bootfileparam.go Show resolved Hide resolved
dhcpv6/option_bootfileparam.go Outdated Show resolved Hide resolved
@xaionaro
Copy link
Contributor Author

xaionaro commented Dec 12, 2019 •
edited
Loading

I've fixed everything what was requested :)

pmazzini
pmazzini previously approved these changes Dec 12, 2019
View reviewed changes
@xaionaro
[dhcpv6] Add option BootfileParam to DHCPv6 client
f09a639 
Added support of option OptBootFileParam.
See RFC5970 section 3.2.

Signed-off-by: Dmitrii Okunev <[email protected]>
@xaionaro
[netboot] Add support of BootfileParam to "netboot"
ab246f0 
Signed-off-by: Dmitrii Okunev <[email protected]>
Natolumin
Natolumin approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@Natolumin Natolumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me as well

@insomniacslk insomniacslk merged commit b3fbc9f into insomniacslk:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insomniacslk insomniacslk insomniacslk approved these changes

@Natolumin Natolumin Natolumin approved these changes

@pmazzini pmazzini pmazzini left review comments

@hugelgupf hugelgupf Awaiting requested review from hugelgupf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xaionaro @Natolumin @hugelgupf @insomniacslk @pmazzini