16.set schedule timers #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted connect to device
Deleted connect to device
Deleted connect to device
Deleted connect to device
Deleted conect to device
…_class 27.create weatherstation class
Update LawnMower.py
|
Rozpiszę to co omawialiśmy sobie podczas zajęć w trochę zmienionej formie.
Klasa
a także metody
|
dylodylo
reviewed
Dec 8, 2024
There was a problem hiding this comment.
Czemu usunęłaś te wszystkie pliki?
| self.turn_off_time = turn_off_time ("%Y-%m-%d-%H-%M") | ||
| self.working_duration = working_duration("%M") | ||
| self.current_time = current_time | ||
| self.task_list = task_list |
There was a problem hiding this comment.
Wydaje mi się, że task_list domyślnie powinien być pustą listą, raczej nie ma sensu tworzyć nowego Schedulera już z taskami.
| self.turn_on_time = turn_on_time ("%Y-%m-%d-%H-%M") | ||
| self.turn_off_time = turn_off_time ("%Y-%m-%d-%H-%M") | ||
| self.working_duration = working_duration("%M") | ||
| self.current_time = current_time |
There was a problem hiding this comment.
Po co zapisywać obecny czas?
Comment on lines
+9
to
+10
| self.turn_on_time = turn_on_time ("%Y-%m-%d-%H-%M") | ||
| self.turn_off_time = turn_off_time ("%Y-%m-%d-%H-%M") |
There was a problem hiding this comment.
- Nie widzę tu tych funkcji
turn_on_timeiturn_off_time, więc nie wiem, co miałoby być wywoływane. - Moim zdaniem, tu wystarczy jeden atrybut,
change_timei drugi, który będzie enumem, mówiący nam co trzeba zrobić, czylichange_action.
| def __init__(self, turn_on_time, turn_off_time, working_duration, current_time = str(datetime.now()), task_list = []): | ||
| self.turn_on_time = turn_on_time ("%Y-%m-%d-%H-%M") | ||
| self.turn_off_time = turn_off_time ("%Y-%m-%d-%H-%M") | ||
| self.working_duration = working_duration("%M") |
There was a problem hiding this comment.
Biorąc pod uwagę komentarz wyżej, ten atrybut też jest niepotrzebny.
| self.current_time = current_time | ||
| self.task_list = task_list | ||
|
|
||
| def load_devices(self) -> Dict[str, Any]: |
There was a problem hiding this comment.
Masz już funkcję load_devices w ui_terminal.py, nie powinnaś jej kopiować, tylko zaimportować.
https://www.geeksforgeeks.org/dont-repeat-yourselfdry-in-software-development/
| print("Error reading the file.") | ||
| return {"devices": []} | ||
|
|
||
| def print_devices(self, devices_data: Dict[str, Any]) -> None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class for scheduling working time
Methods:
Checking list of tasks and turnong-on/ -off devices