Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement visit_seq too? #83

Open
carols10cents opened this issue Nov 23, 2022 · 1 comment
Open

Implement visit_seq too? #83

carols10cents opened this issue Nov 23, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@carols10cents
Copy link
Contributor

Currently, the Deserializer impls generated by pbjson can't be used with bincode, because bincode uses visit_seq and pbjson only implements visit_map.

Now, this is pbJSON, and serde_json only uses visit_map, so that's definitely an argument for not generating visit_seq in this crate.

However, implementing it here would make the generated impls arguably more correct, make them more flexible, and be in line with serde recommendations.

Are there any reasons visit_seq can't be implemented?
@tustvold
Copy link
Contributor

Are there any reasons visit_seq can't be implemented?

Nope, I would be very happy to review a PR that added support for this

@tustvold tustvold added the help wanted Extra attention is needed label Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carols10cents @tustvold