Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully Qualify Standard Library Types in Generated Code #80

Open
tustvold opened this issue Oct 26, 2022 · 0 comments
Open

Fully Qualify Standard Library Types in Generated Code #80

tustvold opened this issue Oct 26, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tustvold
Copy link
Contributor

The generated code does not consistently fully qualify all standard library types - in particular there are non-fully qualified Vec, Result and partially qualifies std::collections::BTreeMap.

This is liable to result in name collisions with the generated code, or other types which may be in scope.

All types should be fully qualified, e.g. ::std::vec::Vec

@tustvold tustvold added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant