Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte fix when using deferred props #2026

Closed
wants to merge 2 commits into from

Conversation

saml-dev
Copy link

This fixes #2012

@saml-dev
Copy link
Author

I just added tests. When I updated server.js to return an object to Page1 instead of text, it caused the svelte and react tests to fail, but strangely I couldn't get the Vue tests to fail. I updated Page1.vue anyway but let me know if I'm missing something there.

@pedroborges
Copy link
Collaborator

Thanks for working on this, @saml-dev. After reviewing this change, I realized it could potentially cause significant compatibility issues for existing projects. Instead, I developed an approach that makes $page updates more predictable and implemented another fix for the <Deferred /> component.

I would greatly appreciate it if you could test these PRs and provide your feedback. 🙏

@reinink
Copy link
Member

reinink commented Oct 18, 2024

@saml-dev Hey thanks so much for this contribution, but as @pedroborges mentioned he's solved this in a slightly different way in #2037, which I just merged in. Thanks so much either way! 🙏

@reinink reinink closed this Oct 18, 2024
@saml-dev
Copy link
Author

Hey no problem! It was a good exercise to get familiar with the Inertia code base. Hopefully I can contribute another way in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deferred svelte component renders the default slot too early
3 participants