Added support for Vite in installer #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed the installer is still using old inertia packages instead of the ones introduce with Inertia 1.0 I just went through the process of setting up a project for Rails 7 with Vue 3, typescript 5, pinia, eslint, vite 4 and inertia 1 manually so I have a fairly good idea of what needs to be done. I could try to update the generator if you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured it wouldn't take too long so in the end I did a first draft today.
I have no idea how to test this in my local environment so it has not been tested, sorry about that.
If you deem it necessary feel free to give me a hint on the procedure and I'll do that
The idea is simple, we check if vite is installed and we store that boolean in a
@vite_installed?variable.We then use that variable to render paths accordingly
The
vite_source_code_dirmethod is used to read theconfig/vite.jsonfile and grab path to the sourceDir there in case some users have changed that path in their config. It also verifies whether the path includes a closing "/" or not and adds it it's not the case. Again that is to unsure that it wouldn't conflict with different user's configI created an instances variables instead of methods for
@vite_installed?and@vite_source_code_dirbecause I wanted to avoid reading the file or executingrails vite:verify_installmultiple times.Closes #85