Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use etnservice as a dependency and drop _sql helpers #316

Open
Tracked by #280
PietrH opened this issue Sep 26, 2024 · 1 comment · May be fixed by #317
Open
Tracked by #280

Use etnservice as a dependency and drop _sql helpers #316

PietrH opened this issue Sep 26, 2024 · 1 comment · May be fixed by #317
Assignees
@PietrH
Labels
API blocked
Milestone
v2.3.1

Comments

@PietrH
Copy link
Member

PietrH commented Sep 26, 2024 •
edited
Loading

In etnservice all functions require a credentials argument which consists of a list of username and password.

-> This could be created using get_credentials()
@PietrH PietrH mentioned this issue Sep 26, 2024
Open
3 tasks
@PietrH PietrH added the API label Sep 26, 2024
@PietrH PietrH self-assigned this Sep 26, 2024
@PietrH
Copy link
Member Author

PietrH commented Sep 27, 2024

Not working because etnservice is dependent on etn by accident, causing a circle dependency, issue: inbo/etnservice#45

Should be fixed in etnservice first

@PietrH PietrH added the blocked label Sep 27, 2024
@PietrH PietrH modified the milestone: v2.3 Sep 30, 2024
@PietrH PietrH linked a pull request Oct 18, 2024 that will close this issue
316 use etnservice as a dependency and drop sql helpers #317
Open
8 tasks
@PietrH PietrH added this to the v2.3.1 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PietrH PietrH

Labels
API blocked
Projects
None yet
Milestone
v2.3.1
1 participant
@PietrH