Make ui look more obvious and accessible #83
Comments
imranariffin
added a commit
that referenced
this issue
Jan 26, 2020
imranariffin
added a commit
that referenced
this issue
Jan 26, 2020
imranariffin
added a commit
that referenced
this issue
Jan 30, 2020
* Use npm standard for linting * Setup key for debug app * Configure debug, dev and release builds * Three build types - debug, dev and release - each with their own keystore * Each build will use their own .env* file. .env.debug is not gitignored * Define npm script for each build type * Display NODE_ENV * Move js codes to app/ directory * Setup enzyme with jest * Use dummy api client to display dummy goals * Ensure http client handle 5xx non-json-parseable response * Mock fetch for debugging while api not ready * Feature/mockup goals list screen (#1) * Ignore `Remote debugger` warning * Display goals as a list * Use grey color for Goal list when touched * Display created date * Fix lint npm script * Delint * Use standardjs with eslint to support es7 * Rename .eslintrc to .eslintrc.json * Ensure test run after lint * Simplify test script: run lint pre test * Feature/setup redux (#2) * Setup redux * Add more tests to goals reducer * Enforce minimum node and npm version * Organize layout of goal list item * Display status icon on right and expand/collapse on left * Feature/allow add new goals (#3) * Mock `POST /goals/` response * Define create/submit goals thunks * Fixup prev * Define action and update reducer for goals creation * Provide ui to add new goals * Refactor/mock fetch use json file as mock response (#4) * Use json files for mock response * Delint * Make mock response include status * Make mock response include status for goals-created * Add end-of-file line break * Feature/display tasks (#5) * Refactor Goal style to enable nested sub children * Display nested tasks * Delint * Define `tasks` reducer for request and success task fetch * Define `tasks` reducer for fetch failure * Define fetch tasks thunk * Fix erroneous test in tasks reducer * Fix fetch tasks thunk endpoint * Install tasks reducer into store * Mock fetch tasks response and demo * Delint * Define selector to get tasks by parent id * Display tasks within a goal * Bug/tasks not displayed properly (#6) * Display subtasks row-by-row instead of col-by-col * Fix sub-tasks of a task not showing * Fix style: ensure line length < 80 * Remove redundant styling * Fix failing Goal component test * Enhance/break down test files (#7) * Separate tests by status codes * Fixed typo in file name * Rename test file properly * Break down selector test files by selector * Feature / 8 / Make screen scrollable (#16) * Make screen scrollable * Maintain column-reverse ordering of list items * Feature/15/add new tasks (#20) * Refactor GoalList component into its own folder * Rename Goal to Item to make it reusable * Move logic out of `Item` component into presenter * Provide propTypes to `Item` component * Add prop-types to `ButtonContainer` component * Rename test file name to be consistent & descriptive * Extract a generic component `ItemAdd` out of `GoalAdd` * Create new component `TaskAdd` * Add tests to App presenters * Define thunk create new task * Make create task thunk handle failure * Refactor test to ensure action dispatch in right order * Define isFormActive selector in forms model * Define forms reducer * Define `forms` action `formsRegister` * Define getParentId tasks selector * Enable add new task * Toggle TaskAdd to GoalAdd after tasks creation success * Make `parentId` not required in `TaskAdd` * Provide proptypes to all components (#21) * Feature/14/change app name to small steps (#23) * Change package name from `mg` to `ss` * Provide missing props in tests * Change repo name and README title * Change api host to small-steps-api.com * Change android name and settings, gitignore * Feature/22/Remove ios support (#25) * Feature/22/Remove xcode gitignore (#26) * Remove ios support * Remove Xcode gitignore * Fix typo * Feature/9/Use new SS icon (#27) * Feature/Modify left-right padding to better center (#28) * Enhance/29/Add development notes to README (#30) * Add development notes to README * Add step to ensure emulator/device running * Bug/31/Cant cancel once start adding task (#37) * Show correct button on long-pressing goal/task * On cancel adding Task, switch button to add goal * Use different color TaskAdd vs GoalAdd button * Feature/38/Enable actions on selected item (#39) * Display item actions on long-press * Display item actions on item click The actions are add task, edit and delete. They are dummy for now. They are touchable text to keep the ui simple. * Remove TaskAdd form at bottom of screen * Feature/35/enable edit task (#43) * WIP Toggle task edit form with goal add form * Make http patch call on edit task text submit * Update task text in state on sucessful update * Mock successful patch tasks * Fix test in App handleComponentDidMount * Remove debug console logs * Add prop types and unit tests * Rename component ItemAdd to ItemAddEdit to be accurate * Add unit tests to TaskEdit mapStateProps * Fix crash and prop type warnings (#44) * Feature 45: Use local service part 1 (#49) * Init goals service create * Allow thunk middleware take in multiple services * Install logger & goals services into middlewares * Use (mock) storage in goals thunks create * Clear prop type warning temporarily * Bugfix 50: Rename java source dir magoals -> smallsteps (#51) * Bugfix 52: Fix wrong proptype being used (#53) * Bump handlebars from 4.1.2 to 4.5.3 - Dependabot (#55) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]> * Feature 45: Use Async storage (#57) * Use async storage for goals create & fetch * Use async storage for tasks fetch, create & edit text * Bugfix 58: Fix java main source path (#59) * Feature 60: Enable add tasks for goals & tasks (#62) * Feature #33: Enable delete task (#63) * WIP: Delete tasks along with subtasks * Add tests to storage task delete * Feature 64: Setup ci tests on branch push (#65) * Setup circleci config file * Set to run on develop, feature/* & bugfix/* branches * Use image with node version=10 * Lint and then test verbose * Use cache * Display test coverage * Add status badge * Feature #64: Display code coverage (#66) * Upload coverage results to codecov * Not use junit * Use circleci config v2.1 * Feature #64: Add codecov status badge (#68) * Feature #32: Enable change task status (#69) * Add buttons to trigger task status update form * Display task status update form * Display icons as buttons for set status * Install styled components lib * Make thunks update multiple task statuses * Define task service to update status * Refactor tasks service set status tests * Make async storage mock global * Ensure tasks set status handle deeply nesting * Ensure task set status return affected statuses * Update tasks thunk set status tests * Ensure allow set status only non-parent task * Display set status button only on innermost * Feature #71: Trigger goal status update (#73) * Define goals middleware to set status Triggered by successful tasks set status * Install goals update status middleware * Make middleware trigger actions to update state * Define goals service to update goal * Make Goals service update handle edge cases * Add more tests to goals thunk update status * Add tests to storage goals service * Feature #48: Display splash screen on app startup (#75) Yarn install react-native-splash-screen Add splash icons and colors Define splash screen layout Display & smoothly hide splash screen Display app name on splash screen Add new lines at eof for Android files Use styled component for styling * Bugfix #74 Round icon launcher not defined (#76) * Define correct round launcher icon assets * Use new square icon launcher consistent w round * Feature #77: Enable delete goal (#78) * Change ItemDeleteConfirm to TaskDeleteConfirm * Define GoalDeleteConfirm form * Define action creator to simplify action definitions * Define goals delete thunk * Define delete goals service * Ensure GoalDeleteConfirm correctly instantiated * Ensure deleted goal removed from state * Feature #36: Enable edit goal text (#80) * Display & hide GoalEdit form * Ensure GoalEdi form handle text changes * Ensure GoalEdit form handle text changes * WIP: Ensure goals service able to update text * Ensure goal text updated in state * Feature #83: Enable cancel delete item (#85) * WIP: Enable cancel delete item * Delint * Fix styled components warnings * Feature #83: Do not display set status for goals (#86) * Do not display set status for goals * Add tests to logger service * Set correct version * Fix long description in README * Modify Android package name to avoid conflict * Display feature graphic as preview on README * Remove unused preview image * Use relative for preview image path Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
imranariffin
added a commit
that referenced
this issue
Jan 30, 2020
* Use npm standard for linting * Setup key for debug app * Configure debug, dev and release builds * Three build types - debug, dev and release - each with their own keystore * Each build will use their own .env* file. .env.debug is not gitignored * Define npm script for each build type * Display NODE_ENV * Move js codes to app/ directory * Setup enzyme with jest * Use dummy api client to display dummy goals * Ensure http client handle 5xx non-json-parseable response * Mock fetch for debugging while api not ready * Feature/mockup goals list screen (#1) * Ignore `Remote debugger` warning * Display goals as a list * Use grey color for Goal list when touched * Display created date * Fix lint npm script * Delint * Use standardjs with eslint to support es7 * Rename .eslintrc to .eslintrc.json * Ensure test run after lint * Simplify test script: run lint pre test * Feature/setup redux (#2) * Setup redux * Add more tests to goals reducer * Enforce minimum node and npm version * Organize layout of goal list item * Display status icon on right and expand/collapse on left * Feature/allow add new goals (#3) * Mock `POST /goals/` response * Define create/submit goals thunks * Fixup prev * Define action and update reducer for goals creation * Provide ui to add new goals * Refactor/mock fetch use json file as mock response (#4) * Use json files for mock response * Delint * Make mock response include status * Make mock response include status for goals-created * Add end-of-file line break * Feature/display tasks (#5) * Refactor Goal style to enable nested sub children * Display nested tasks * Delint * Define `tasks` reducer for request and success task fetch * Define `tasks` reducer for fetch failure * Define fetch tasks thunk * Fix erroneous test in tasks reducer * Fix fetch tasks thunk endpoint * Install tasks reducer into store * Mock fetch tasks response and demo * Delint * Define selector to get tasks by parent id * Display tasks within a goal * Bug/tasks not displayed properly (#6) * Display subtasks row-by-row instead of col-by-col * Fix sub-tasks of a task not showing * Fix style: ensure line length < 80 * Remove redundant styling * Fix failing Goal component test * Enhance/break down test files (#7) * Separate tests by status codes * Fixed typo in file name * Rename test file properly * Break down selector test files by selector * Feature / 8 / Make screen scrollable (#16) * Make screen scrollable * Maintain column-reverse ordering of list items * Feature/15/add new tasks (#20) * Refactor GoalList component into its own folder * Rename Goal to Item to make it reusable * Move logic out of `Item` component into presenter * Provide propTypes to `Item` component * Add prop-types to `ButtonContainer` component * Rename test file name to be consistent & descriptive * Extract a generic component `ItemAdd` out of `GoalAdd` * Create new component `TaskAdd` * Add tests to App presenters * Define thunk create new task * Make create task thunk handle failure * Refactor test to ensure action dispatch in right order * Define isFormActive selector in forms model * Define forms reducer * Define `forms` action `formsRegister` * Define getParentId tasks selector * Enable add new task * Toggle TaskAdd to GoalAdd after tasks creation success * Make `parentId` not required in `TaskAdd` * Provide proptypes to all components (#21) * Feature/14/change app name to small steps (#23) * Change package name from `mg` to `ss` * Provide missing props in tests * Change repo name and README title * Change api host to small-steps-api.com * Change android name and settings, gitignore * Feature/22/Remove ios support (#25) * Feature/22/Remove xcode gitignore (#26) * Remove ios support * Remove Xcode gitignore * Fix typo * Feature/9/Use new SS icon (#27) * Feature/Modify left-right padding to better center (#28) * Enhance/29/Add development notes to README (#30) * Add development notes to README * Add step to ensure emulator/device running * Bug/31/Cant cancel once start adding task (#37) * Show correct button on long-pressing goal/task * On cancel adding Task, switch button to add goal * Use different color TaskAdd vs GoalAdd button * Feature/38/Enable actions on selected item (#39) * Display item actions on long-press * Display item actions on item click The actions are add task, edit and delete. They are dummy for now. They are touchable text to keep the ui simple. * Remove TaskAdd form at bottom of screen * Feature/35/enable edit task (#43) * WIP Toggle task edit form with goal add form * Make http patch call on edit task text submit * Update task text in state on sucessful update * Mock successful patch tasks * Fix test in App handleComponentDidMount * Remove debug console logs * Add prop types and unit tests * Rename component ItemAdd to ItemAddEdit to be accurate * Add unit tests to TaskEdit mapStateProps * Fix crash and prop type warnings (#44) * Feature 45: Use local service part 1 (#49) * Init goals service create * Allow thunk middleware take in multiple services * Install logger & goals services into middlewares * Use (mock) storage in goals thunks create * Clear prop type warning temporarily * Bugfix 50: Rename java source dir magoals -> smallsteps (#51) * Bugfix 52: Fix wrong proptype being used (#53) * Bump handlebars from 4.1.2 to 4.5.3 - Dependabot (#55) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]> * Feature 45: Use Async storage (#57) * Use async storage for goals create & fetch * Use async storage for tasks fetch, create & edit text * Bugfix 58: Fix java main source path (#59) * Feature 60: Enable add tasks for goals & tasks (#62) * Feature #33: Enable delete task (#63) * WIP: Delete tasks along with subtasks * Add tests to storage task delete * Feature 64: Setup ci tests on branch push (#65) * Setup circleci config file * Set to run on develop, feature/* & bugfix/* branches * Use image with node version=10 * Lint and then test verbose * Use cache * Display test coverage * Add status badge * Feature #64: Display code coverage (#66) * Upload coverage results to codecov * Not use junit * Use circleci config v2.1 * Feature #64: Add codecov status badge (#68) * Feature #32: Enable change task status (#69) * Add buttons to trigger task status update form * Display task status update form * Display icons as buttons for set status * Install styled components lib * Make thunks update multiple task statuses * Define task service to update status * Refactor tasks service set status tests * Make async storage mock global * Ensure tasks set status handle deeply nesting * Ensure task set status return affected statuses * Update tasks thunk set status tests * Ensure allow set status only non-parent task * Display set status button only on innermost * Feature #71: Trigger goal status update (#73) * Define goals middleware to set status Triggered by successful tasks set status * Install goals update status middleware * Make middleware trigger actions to update state * Define goals service to update goal * Make Goals service update handle edge cases * Add more tests to goals thunk update status * Add tests to storage goals service * Feature #48: Display splash screen on app startup (#75) Yarn install react-native-splash-screen Add splash icons and colors Define splash screen layout Display & smoothly hide splash screen Display app name on splash screen Add new lines at eof for Android files Use styled component for styling * Bugfix #74 Round icon launcher not defined (#76) * Define correct round launcher icon assets * Use new square icon launcher consistent w round * Feature #77: Enable delete goal (#78) * Change ItemDeleteConfirm to TaskDeleteConfirm * Define GoalDeleteConfirm form * Define action creator to simplify action definitions * Define goals delete thunk * Define delete goals service * Ensure GoalDeleteConfirm correctly instantiated * Ensure deleted goal removed from state * Feature #36: Enable edit goal text (#80) * Display & hide GoalEdit form * Ensure GoalEdi form handle text changes * Ensure GoalEdit form handle text changes * WIP: Ensure goals service able to update text * Ensure goal text updated in state * Feature #83: Enable cancel delete item (#85) * WIP: Enable cancel delete item * Delint * Fix styled components warnings * Feature #83: Do not display set status for goals (#86) * Do not display set status for goals * Add tests to logger service * Set correct version * Fix long description in README * Modify Android package name to avoid conflict * Display feature graphic as preview on README * Remove unused preview image * Use relative for preview image path Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
imranariffin
added a commit
that referenced
this issue
Jan 30, 2020
* Release #84: 1.0.0 (#88) * Use npm standard for linting * Setup key for debug app * Configure debug, dev and release builds * Three build types - debug, dev and release - each with their own keystore * Each build will use their own .env* file. .env.debug is not gitignored * Define npm script for each build type * Display NODE_ENV * Move js codes to app/ directory * Setup enzyme with jest * Use dummy api client to display dummy goals * Ensure http client handle 5xx non-json-parseable response * Mock fetch for debugging while api not ready * Feature/mockup goals list screen (#1) * Ignore `Remote debugger` warning * Display goals as a list * Use grey color for Goal list when touched * Display created date * Fix lint npm script * Delint * Use standardjs with eslint to support es7 * Rename .eslintrc to .eslintrc.json * Ensure test run after lint * Simplify test script: run lint pre test * Feature/setup redux (#2) * Setup redux * Add more tests to goals reducer * Enforce minimum node and npm version * Organize layout of goal list item * Display status icon on right and expand/collapse on left * Feature/allow add new goals (#3) * Mock `POST /goals/` response * Define create/submit goals thunks * Fixup prev * Define action and update reducer for goals creation * Provide ui to add new goals * Refactor/mock fetch use json file as mock response (#4) * Use json files for mock response * Delint * Make mock response include status * Make mock response include status for goals-created * Add end-of-file line break * Feature/display tasks (#5) * Refactor Goal style to enable nested sub children * Display nested tasks * Delint * Define `tasks` reducer for request and success task fetch * Define `tasks` reducer for fetch failure * Define fetch tasks thunk * Fix erroneous test in tasks reducer * Fix fetch tasks thunk endpoint * Install tasks reducer into store * Mock fetch tasks response and demo * Delint * Define selector to get tasks by parent id * Display tasks within a goal * Bug/tasks not displayed properly (#6) * Display subtasks row-by-row instead of col-by-col * Fix sub-tasks of a task not showing * Fix style: ensure line length < 80 * Remove redundant styling * Fix failing Goal component test * Enhance/break down test files (#7) * Separate tests by status codes * Fixed typo in file name * Rename test file properly * Break down selector test files by selector * Feature / 8 / Make screen scrollable (#16) * Make screen scrollable * Maintain column-reverse ordering of list items * Feature/15/add new tasks (#20) * Refactor GoalList component into its own folder * Rename Goal to Item to make it reusable * Move logic out of `Item` component into presenter * Provide propTypes to `Item` component * Add prop-types to `ButtonContainer` component * Rename test file name to be consistent & descriptive * Extract a generic component `ItemAdd` out of `GoalAdd` * Create new component `TaskAdd` * Add tests to App presenters * Define thunk create new task * Make create task thunk handle failure * Refactor test to ensure action dispatch in right order * Define isFormActive selector in forms model * Define forms reducer * Define `forms` action `formsRegister` * Define getParentId tasks selector * Enable add new task * Toggle TaskAdd to GoalAdd after tasks creation success * Make `parentId` not required in `TaskAdd` * Provide proptypes to all components (#21) * Feature/14/change app name to small steps (#23) * Change package name from `mg` to `ss` * Provide missing props in tests * Change repo name and README title * Change api host to small-steps-api.com * Change android name and settings, gitignore * Feature/22/Remove ios support (#25) * Feature/22/Remove xcode gitignore (#26) * Remove ios support * Remove Xcode gitignore * Fix typo * Feature/9/Use new SS icon (#27) * Feature/Modify left-right padding to better center (#28) * Enhance/29/Add development notes to README (#30) * Add development notes to README * Add step to ensure emulator/device running * Bug/31/Cant cancel once start adding task (#37) * Show correct button on long-pressing goal/task * On cancel adding Task, switch button to add goal * Use different color TaskAdd vs GoalAdd button * Feature/38/Enable actions on selected item (#39) * Display item actions on long-press * Display item actions on item click The actions are add task, edit and delete. They are dummy for now. They are touchable text to keep the ui simple. * Remove TaskAdd form at bottom of screen * Feature/35/enable edit task (#43) * WIP Toggle task edit form with goal add form * Make http patch call on edit task text submit * Update task text in state on sucessful update * Mock successful patch tasks * Fix test in App handleComponentDidMount * Remove debug console logs * Add prop types and unit tests * Rename component ItemAdd to ItemAddEdit to be accurate * Add unit tests to TaskEdit mapStateProps * Fix crash and prop type warnings (#44) * Feature 45: Use local service part 1 (#49) * Init goals service create * Allow thunk middleware take in multiple services * Install logger & goals services into middlewares * Use (mock) storage in goals thunks create * Clear prop type warning temporarily * Bugfix 50: Rename java source dir magoals -> smallsteps (#51) * Bugfix 52: Fix wrong proptype being used (#53) * Bump handlebars from 4.1.2 to 4.5.3 - Dependabot (#55) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]> * Feature 45: Use Async storage (#57) * Use async storage for goals create & fetch * Use async storage for tasks fetch, create & edit text * Bugfix 58: Fix java main source path (#59) * Feature 60: Enable add tasks for goals & tasks (#62) * Feature #33: Enable delete task (#63) * WIP: Delete tasks along with subtasks * Add tests to storage task delete * Feature 64: Setup ci tests on branch push (#65) * Setup circleci config file * Set to run on develop, feature/* & bugfix/* branches * Use image with node version=10 * Lint and then test verbose * Use cache * Display test coverage * Add status badge * Feature #64: Display code coverage (#66) * Upload coverage results to codecov * Not use junit * Use circleci config v2.1 * Feature #64: Add codecov status badge (#68) * Feature #32: Enable change task status (#69) * Add buttons to trigger task status update form * Display task status update form * Display icons as buttons for set status * Install styled components lib * Make thunks update multiple task statuses * Define task service to update status * Refactor tasks service set status tests * Make async storage mock global * Ensure tasks set status handle deeply nesting * Ensure task set status return affected statuses * Update tasks thunk set status tests * Ensure allow set status only non-parent task * Display set status button only on innermost * Feature #71: Trigger goal status update (#73) * Define goals middleware to set status Triggered by successful tasks set status * Install goals update status middleware * Make middleware trigger actions to update state * Define goals service to update goal * Make Goals service update handle edge cases * Add more tests to goals thunk update status * Add tests to storage goals service * Feature #48: Display splash screen on app startup (#75) Yarn install react-native-splash-screen Add splash icons and colors Define splash screen layout Display & smoothly hide splash screen Display app name on splash screen Add new lines at eof for Android files Use styled component for styling * Bugfix #74 Round icon launcher not defined (#76) * Define correct round launcher icon assets * Use new square icon launcher consistent w round * Feature #77: Enable delete goal (#78) * Change ItemDeleteConfirm to TaskDeleteConfirm * Define GoalDeleteConfirm form * Define action creator to simplify action definitions * Define goals delete thunk * Define delete goals service * Ensure GoalDeleteConfirm correctly instantiated * Ensure deleted goal removed from state * Feature #36: Enable edit goal text (#80) * Display & hide GoalEdit form * Ensure GoalEdi form handle text changes * Ensure GoalEdit form handle text changes * WIP: Ensure goals service able to update text * Ensure goal text updated in state * Feature #83: Enable cancel delete item (#85) * WIP: Enable cancel delete item * Delint * Fix styled components warnings * Feature #83: Do not display set status for goals (#86) * Do not display set status for goals * Add tests to logger service * Set correct version * Fix long description in README * Modify Android package name to avoid conflict * Display feature graphic as preview on README * Remove unused preview image * Use relative for preview image path Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix rebase conflicts Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: