Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimated inverses should be more robust #45

Open
bogovicj opened this issue Mar 12, 2024 · 4 comments
Open

Estimated inverses should be more robust #45

bogovicj opened this issue Mar 12, 2024 · 4 comments

Comments

@bogovicj
Copy link
Contributor

Iterative estimation of inverses can behave poorly at times.

It seems more likely to occur when the transformation has a large scale component.

See
https://forum.image.sc/t/how-to-transform-points-locations-csv-with-bigwarp/35368/21?u=bogovicj

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/how-to-transform-points-locations-csv-with-bigwarp/35368/24

@NicoKiaru
Copy link
Contributor

I've had the same issue while trying to adapt my code to the new BigWarp version.

The use case is a bit different I think. I have to double check. The jacobian is not invertible - the third column is 0 0 0 0.

it pops up in the "VOLUME" bounding box estimator - I don't have the full stack trace, but it fails in:

  • InverseRealTransformGradientDescent#inverseTol
  • RealTransformFiniteDerivatives#jacobian
  • this.jacobian.set(newjac); -> newjac is not invertible.

@bogovicj
Copy link
Contributor Author

bogovicj commented Apr 1, 2024

Started some work toward this here:
https://github.com/imglib/imglib2-realtransform/tree/inverseRefactorEjml
but needs testing.

Most immediately relevant for the "The jacobian is not invertible" is that I now use an EJML DMatrixRMaj to store the jacobian rather than an AffineTransform. The latter complains when its not invertible.

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/bigwarp-no-brightness-colour/95092/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants