Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: ACES 1.1 and ACES 1.2 Support #21

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

KelSolaar
Copy link
Contributor

Hello,

After almost 2.5 years, it is about time that this comes back under the original roof! This PR provides support for ACES 1.1, ACES 1.2 and add the A.M.P.A.S. license to the Academy mandated work.

Merging this PR will require some work to be able to re-tag the relevant commits, it also cannot be squashed to a single commit because of that.

ACES 1.1

ACES 1.2

License

With the contributors agreeing to release their contributions to the aces_1.0.1, aces_1.0.2, aces_1.0.3, aces_1.1 and aces_1.2 directories under the License Terms for Academy Color Encoding System Components, we can finally have an explicit license for the Academy mandated work. See the following PRs for more context:

The Future

A new config generator is being produced over here: https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES with the intent to supersede this repository. A few reasons to do so:

  • This repository, i.e. imageworks/OpenColorIO-Configs, did not have a license for a long time which had put us in muddy waters to re-use any code.
  • This repository is massive and is a major trauma to work with (as the maintainer of the ACES 1.1 and ACES 1.2 configs, I hope you can take my word for it).
  • We want to leverage OCIO 2 capabilities and especially its BuiltinTransform(s) which make obsolete the LUT based approach of this repository.

With that in mind, and when we have new Configs, we would be keen to archive this repository and the colour-science fork, i.e. colour-science/OpenColorIO-Configs. We can open a new issue to discuss further!

Cheers,

Thomas

Note that the order of the "ColorSpace"s is different because of changes in YamlCpp version.
PR: Add "A.M.P.A.S." license to Academy mandated work and contributions.
… it has explicit and refined statements about distribution and is the license referenced in the new SPDX headers.

Principal differences around the concept of "distribution" are as follows:

*aces-dev* License

A worldwide, royalty-free, non-exclusive right to copy, modify, create derivatives, and use, in source and binary forms, is hereby granted, subject to acceptance of this license.

[...]

Copies of source code, in whole or in part, must retain the above copyright notice, this list of conditions and the Disclaimer of Warranty.

*AMPAS* License

A world-wide, royalty-free, non-exclusive right to distribute, copy, modify, create derivatives, and use, in source and binary forms, is hereby granted, subject to acceptance of this license.

[...]

Redistributions of source code must retain the above copyright notice, this list of conditions and the Disclaimer of Warranty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants