Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guess_java_version would fail for build versions > 255 #67

Open
ctrueden opened this issue Sep 30, 2019 · 0 comments
Open

guess_java_version would fail for build versions > 255 #67

ctrueden opened this issue Sep 30, 2019 · 0 comments

Comments

@ctrueden
Copy link
Member

The guess_java_version method encodes the major, minor, patch and build versions into 8-bit chunks of a 32-bit int. If any of these values exceeds 255, it would overflow. In the case of the build version, nothing consumes it, so maybe this is not a problem. But filing here just in case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctrueden