Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show AppVeyor Status in pull requests #301

Closed
mrmonday opened this issue Apr 24, 2019 · 6 comments
Closed

Show AppVeyor Status in pull requests #301

mrmonday opened this issue Apr 24, 2019 · 6 comments

Comments

@mrmonday
Copy link
Contributor

mrmonday commented Apr 24, 2019

It would be great if the AppVeyor status showed in pull requests.

Status can be seen here, but not on the PR itself - https://ci.appveyor.com/project/icsharpcode/codeconverter/history

@christophwille
Copy link
Member

AppVeyor is active for pull_request and push, see https://ci.appveyor.com/project/icsharpcode/codeconverter/history

@mrmonday mrmonday changed the title Add continuous integration for the test suite Show AppVeyor Status in pull requests Apr 24, 2019
@mrmonday
Copy link
Contributor Author

Thanks. I've updated the issue - didn't realise we already had CI, it wasn't visible!

You can set it up to show on PRs, eg. libpnet/libpnet#363 (comment) (ctrl-f for "check", or scroll to the bottom).

I can't remember how I set this up for libpnet, I assume I clicked through some UI on AppVeyor's side.

@GrahamTheCoder
Copy link
Member

It still works for refactoring essentials e.g., but has never worked on this repo since it was split out. Probably just needs a webhook approximately here to have the right settings the same as refactoring essentials:
https://github.com/icsharpcode/CodeConverter/settings/hooks
I don't have permission to see the page, @christophwille - are you able to check or remove and readd that?

@christophwille
Copy link
Member

christophwille commented Apr 25, 2019

I have asked @dgrunwald what the magic is

@dgrunwald
Copy link
Member

I don't remember any magic.

Maybe some permission problem? Setting statuses requires some form of write access. I don't remember how I set that up with AppVeyor, I guess there was some OAuth stuff involved...

@christophwille
Copy link
Member

Thanks, that was exactly the hint I needed - the build server GH account had only read access, whereas in all other repos it had write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants