Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use angles library for math operations #157

Open
alsora opened this issue Feb 24, 2022 · 4 comments
Open

Use angles library for math operations #157

alsora opened this issue Feb 24, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@alsora
Copy link
Contributor

alsora commented Feb 24, 2022

Is your feature request related to a problem? Please describe.
There are some operations on angles in the irobot_create_toolbox package.
Rather than implementing them here, we should rely on the angles library that is already a dependency of the project.

@alsora alsora added the enhancement New feature or request label Feb 24, 2022
@alsora alsora mentioned this issue Feb 24, 2022
5 tasks
@ckavanagh21
Copy link

Can you be more specific about where the math regarding angles is? I want to help if I can.

@alsora
Copy link
Contributor Author

alsora commented Jul 4, 2023

@ckavanagh21
Copy link

This is what I was able to come up with. I don't know how to run C++ files, so I couldn't test it. I just looked up the syntax for the angles library and modified the code. Do you think this looks right? Also, does the polar_coordinates.hpp file have to be changed as well?

@ksatyaki
Copy link

ksatyaki commented Nov 28, 2024

This might be a different issue, but somewhat related.

Here The calculations for transforming a pose are complicated. and possibly wrong.
Why not simply use tf2::Transform * tf2::Transform (just multiply the transformations). We need (world to some static link). That is simply (world to floating link) * (floating link to static link). Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants