Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitpick: literal newline in fabric.mod.json of 1.2.0 for 1.20.4 artifact #8

Open
YoshiRulz opened this issue Apr 12, 2024 · 5 comments

Comments

@YoshiRulz
Copy link

This doesn't seem to be a problem for the Fabric loader, but a strict parser like jq's will choke on literal newlines in strings.
Since it's not literal in the source:

"description": "Better Than Llamas! #BlameWyld\nhttps://twitter.com/Wyld/status/846489501320982528",

...I'm guessing the process of expanding templates is what introduces it.

@iChun
Copy link
Owner

iChun commented May 19, 2024

I was wondering what specifically your use case for jq was? I'm not very sure how I would otherwise put a new line into the description of the mod in fabric.mod.json, and alternatives for jq was to run the file through sed first, which is really all I could kinda find about the topic.

Happy to hear if you have any suggestions/workarounds for the matter

@YoshiRulz
Copy link
Author

@iChun
Copy link
Owner

iChun commented May 19, 2024

Had a tinker with what you've sent and couldn't find anything that worked. I had a look at the compiled fabric.mod.json and I get what broke now 😂

I've managed to muck up something that might work and leaves the entire description intact in one line, would this be okay with you?

@YoshiRulz
Copy link
Author

Well removing the newline also works, yeah. You just need to use '\n` if you want one.

@iChun
Copy link
Owner

iChun commented May 19, 2024

fabric.mod.json

This is the file gradle spat out after building, just checking with you to make sure it's all okay on your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants