Session closed on external monitor plug

[davc0n]

Hello,

With version 0.3.2 the first time an external monitor is plugged the session gets closed:

Aug 19 09:39:08 thinkpad login[569]: pam_unix(login:session): session closed for user davide
Aug 19 09:39:08 thinkpad login[569]: pam_systemd(login:session): New sd-bus connection (system-bus-pam-systemd-569) opened.
Aug 19 09:39:08 thinkpad systemd[1]: [email protected]: Deactivated successfully.
Aug 19 09:39:08 thinkpad systemd[1]: run-credentials-getty\x40tty1.service.mount: Deactivated successfully.
Aug 19 09:39:08 thinkpad systemd[1]: session-1.scope: Deactivated successfully.
Aug 19 09:39:08 thinkpad systemd[1]: session-1.scope: Consumed 2.190s CPU time, 341.1M memory peak.
Aug 19 09:39:08 thinkpad systemd-logind[477]: Session 1 logged out. Waiting for processes to exit.
Aug 19 09:39:08 thinkpad systemd[1]: [email protected]: Scheduled restart job, restart counter is at 1.
Aug 19 09:39:08 thinkpad systemd[1]: Started Getty on tty1.
Aug 19 09:39:08 thinkpad systemd-logind[477]: Removed session 1.
Aug 19 09:39:08 thinkpad login[815]: pam_systemd_home(login:auth): New sd-bus connection (system-bus-pam-systemd-home-815) opened.

Issue is not present in 0.3.1.

[vaxerski]

can you bisect

[sp0nks]

I hope this is it:

5893461 is the first bad commit
commit 5893461 (HEAD)
Author: Vaxry [email protected]
Date: Thu Aug 15 16:54:05 2024 +0100

DRM: Allow checking no-crtc connectors (#49)

include/aquamarine/backend/DRM.hpp | 2 +-
src/backend/drm/DRM.cpp | 16 ++++++----------
2 files changed, 7 insertions(+), 11 deletions(-)

[vaxerski]

and what does "session gets closed" mean? crash?

[sp0nks]

Yes.

I start Hyprland with only one screen, then a while Hyprland is running I plug in my external screen and Hyprland dies.

[vaxerski]

can you attach a crash report from latest aquamarine-git with latest hyprland-git?

[sp0nks]

Attached is what I could get.

The log and the crash weren't from the same run.

hyprland.log
hyprlandCrashReport657129.txt

[vaxerski]

this crash report looks outdated. That issue was fixed in 0.3.2 iirc

[vaxerski]

and I don't see anything wrong in the log? (Except possibly one monitor being a bit wonk)

[sp0nks]

Apologies. Here is a fresh crash log.
hyprlandCrashReport783249.txt

[vaxerski]

can you build aquamarine in debug and get the crash report again

[sp0nks]

I am going to try, will be back soon...

[sp0nks]

I'm not sure if I did it right, but here is the crash log
hyprlandCrashReport824122.txt

And I also got this:
coredump.txt

[davc0n]

and what does "session gets closed" mean? crash?

Logout (e.g. loginctl terminate-session 1).
Hyprland does not crash.

can you bisect

Maybe next weekend.

[vaxerski]

should be fixed

[vaxerski]

pls verify

[davc0n]

Fixed, thanks.