-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numlock issue still presist #8288
Comments
This comment was marked as outdated.
This comment was marked as outdated.
hmm... doesnt seem to work, but i wonder how would defining a new var that is the same value as the old one and using the new one work. |
Strange. Can you reproduce the issue without numlock on by default? Because I can't. Maybe we're talking about different issues, but it didn't reset for me after more than 20 minutes. But for me without this patch, when numlock is on by default, after config reload it stays on (predictably), including LED, but no longer actually in effect. About the patch
It could work because of this line inside Hyprland/src/devices/IKeyboard.cpp Lines 345 to 346 in d679d20
that checks if Hyprland/src/devices/IKeyboard.cpp Lines 362 to 368 in d679d20
and if it doesn't - then it sends the event that notifies things of these changes. But if Hyprland/src/devices/IKeyboard.cpp Line 340 in d679d20
is always called first, so Hyprland/src/devices/IKeyboard.cpp Lines 362 to 365 in d679d20
So I assumed that So no changes, meaning no event, meaning default state of numlock as off, while leds stay on. |
hmm i see. I will check tmr, it's pretty late here and im abt to sleep |
A proper repro for testing:
EditNever mind lol. I bisected (manually), and GOOD d679d20 seat: avoid sending pointless 'keymap' and 'repeat_info' events (8276) (GOOD - numlock stays on for real after config reload) Checking on 7188ee4 + patch - it doesn't seem to fix it anyway. #8276 is what actually fixed the issue. No patch is needed, update to latest git. |
hang tight, im compiling(with input-capture), i skiped a rebase conflict thats not this commit cuz i dont have time for this. also I cannot repro with hyprctl reload, I have to just wait a while EDIT: nope it didnt not fix it for me, but seems to somewhat mitigate it |
I can reproduce it on my Bluetooth keyboard, maybe it does work with wired? EDIT: |
I had an issue, where my wired numpad didnt work at all even with |
Already reported ? *
Regression?
Yes
System Info and Version
System/Version info
Description
same issue as prev num lock issues, num lock is on, but the input is not number. had to disable and renable to type number and will reset every ~5min(have to repeat above to get numlock working).
im pretty sure this is a reggression and is fixed but is broken again
How to reproduce
Crash reports, logs, images, videos
No response
The text was updated successfully, but these errors were encountered: