Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selectedRow prop from DataTable and add a new prop to toggle multi-row selection #1368

Open
acelaya opened this issue Nov 13, 2023 · 0 comments
Labels

Comments

@acelaya
Copy link
Contributor

acelaya commented Nov 13, 2023

#1360 introduced support for multi-row selection, by adding a new selectedRows prop.

With those changes, DataTable allows multi-row selection only if selectedRows is provided, and single-row selection if selectedRow is instead. However, we have not explicitly handled what happens if both are provided, other than just preferring selectedRows over selectedRow.

To make the props API more obvious, let's remove selectedRow, and add a new prop to enable/disable multi-row selection.

@acelaya acelaya added this to the Version 7 milestone Nov 13, 2023
@acelaya acelaya changed the title Remove selectedRow prop from DataTable and add a new prop to control support for multi-row selection Remove selectedRow prop from DataTable and add a new prop to toggle multi-row selection Nov 13, 2023
@robertknight robertknight removed this from the Version 7 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants