Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pycodestyle configuration from setup.cfg #52

Open
seanh opened this issue Aug 11, 2022 · 0 comments
Open

Remove pycodestyle configuration from setup.cfg #52

seanh opened this issue Aug 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@seanh
Copy link
Contributor

seanh commented Aug 11, 2022

Since it's now possible to move the setuptools configuration from setup.cfg into pyproject.toml (#53) if we can also get the pycodestyle configuration out of setup.cfg then we could get rid of the setup.cfg file entirely and have one less root file.

pycodestyle doesn't support pyproject.toml and it doesn't look like they're going to be adding support any time soon, so for the time being we have two options:

  1. pycodestyle does support reading its configuration from tox.ini so we could move the pycodestyle config from setup.cfg into tox.ini. See https://pycodestyle.pycqa.org/en/latest/intro.html#configuration
  2. We could remove pycodestyle from our projects. How much value does it really provide given that we have Black, isort and Pylint? There's a list of pycodestyle's warnings here: https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes At a glance it doesn't look like to me like pycodestyle is providing any value. All of the warnings look like things that should never happen to Black- and isort-formatted code apart from a handful of warnings that I think Pylint might already cover anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant