Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypackage: cache the .tox directory on GHA #10

Open
seanh opened this issue Jul 7, 2022 · 1 comment
Open

pypackage: cache the .tox directory on GHA #10

seanh opened this issue Jul 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@seanh
Copy link
Contributor

seanh commented Jul 7, 2022

The pypackage cookiecutter should cache the .tox directory on GitHub Actions in the same way as the pyramid-app one does. This might speed up CI and tox-recreate should ensure that the venvs get recreated if setup.cfg changes (and tox itself will recreate the venvs if tox.ini changes).

For packages, which use unpinned dependencies, we actually want the venvs on CI to be re-created over time even if tox.ini and setup.cfg don't change so that we test against new versions of our dependencies as they get released. Caching the .tox dir would defeat that. I wonder if we could disable caching just for the scheduled nightly run of ci.yml?

@seanh seanh added the enhancement New feature or request label Jul 7, 2022
@seanh
Copy link
Contributor Author

seanh commented Jul 7, 2022

I think we might need to add the Python version to the cache key, otherwise tests running in different versions of Python will fight over the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant