Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a Native::Object in component params can't be retrieved #417

Open
lionelchauvin opened this issue Jul 16, 2021 · 1 comment
Open

a Native::Object in component params can't be retrieved #417

lionelchauvin opened this issue Jul 16, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lionelchauvin
Copy link

lionelchauvin commented Jul 16, 2021 •
edited
Loading

A Native::Object is a BasicObject and it doesn't respond to "tap".
It defines method_missing so Native::Object.new.tap returns nil

At hyperstack/ruby/hyper-component/lib/hyperstack/internal/component/props_wrapper.rb:113 .tap returns nil so fetch_from_cache returns nil instead of the Native::Object.

I suggest to rewrite fetch_from_cache without using tap.
@catmando catmando added bug Something isn't working good first issue Good for newcomers labels Aug 3, 2021
@lionelchauvin
Copy link
Author

#418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catmando @lionelchauvin