Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperspec to_js method broken #393

Open
catmando opened this issue Mar 31, 2021 · 0 comments
Open

Hyperspec to_js method broken #393

catmando opened this issue Mar 31, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@catmando
Copy link
Contributor

    def to_js(*args, &block)
      opal_compile(*process_params(*args, &block))
    end

needs to be

    def to_js(*args, &block)
      opal_compile(process_params(*args, &block).first)
    end

(second value from process_params is options for mounting, which opal_compile doesn't need)

Should have a simple spec anyway that says yes I returned a string with length > 0

@catmando catmando added bug Something isn't working good first issue Good for newcomers labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant