Fix: normalize seekTo time argument (#372)

hyochan · Aug 12, 2021 · 9517414 · 9517414
1 parent 64a2051
commit 9517414
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/android/src/main/java/com/dooboolab.audiorecorderplayer/RNAudioRecorderPlayerModule.kt b/android/src/main/java/com/dooboolab.audiorecorderplayer/RNAudioRecorderPlayerModule.kt
@@ -303,14 +303,13 @@ class RNAudioRecorderPlayerModule(private val reactContext: ReactApplicationCont
     }
 
     @ReactMethod
-    fun seekToPlayer(time: Int, promise: Promise) {
+    fun seekToPlayer(time: Double, promise: Promise) {
         if (mediaPlayer == null) {
             promise.reject("seekTo", "mediaPlayer is null on seek.")
             return
         }
 
-        val millis = time * 1000
-        mediaPlayer!!.seekTo(millis)
+        mediaPlayer!!.seekTo(time.toInt())
         promise.resolve("pause player")
     }
 

diff --git a/index.ts b/index.ts
@@ -359,12 +359,10 @@ class AudioRecorderPlayer {
 
   /**
    * Seek to.
-   * @param {number} time position seek to in second.
+   * @param {number} time position seek to in millisecond.
    * @returns {Promise<string>}
    */
   seekToPlayer = async (time: number): Promise<string> => {
-    if (Platform.OS === 'ios') time = time / 1000;
-
     return RNAudioRecorderPlayer.seekToPlayer(time);
   };
 

diff --git a/ios/RNAudioRecorderPlayer.swift b/ios/RNAudioRecorderPlayer.swift
@@ -388,7 +388,7 @@ class RNAudioRecorderPlayer: RCTEventEmitter, AVAudioRecorderDelegate {
             return reject("RNAudioPlayerRecorder", "Player is null", nil)
         }
 
-        audioPlayer.seek(to: CMTime(seconds: time, preferredTimescale: CMTimeScale(NSEC_PER_SEC)))
+        audioPlayer.seek(to: CMTime(seconds: time / 1000, preferredTimescale: CMTimeScale(NSEC_PER_SEC)))
         resolve("Resumed!")
     }