Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly doesn't like CollectionConverters #669

Open
etspaceman opened this issue Mar 16, 2022 · 0 comments
Open

Assembly doesn't like CollectionConverters #669

etspaceman opened this issue Mar 16, 2022 · 0 comments

Comments

@etspaceman
Copy link

Currently, providing the CollectionConverters object manually in the scala.jdk package as a part of Rho causes assembly issues, as projects with dependencies on Rho and the Scala Collection Compat will require conflicts to be resolved.

From what I understand, this was originally done to avoid bincompat issues during updates, as the collection compat library broke some rules early on. This has gotten a lot more stable and is pretty widely used now in the Scala ecosystem, so it seems much safer to include this library.

Another option could be to repackage the collection converters under a new namespace. I could work on that if that is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant