Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image normalisation does not work with grey scale images. #55

Open
jacekpie opened this issue Apr 12, 2022 · 1 comment
Open

Image normalisation does not work with grey scale images. #55

jacekpie opened this issue Apr 12, 2022 · 1 comment
Assignees

Comments

@jacekpie
Copy link
Contributor

I connected grey-scale image source to image normalisation module.
The output from image source is
u8[1, 31, 200, 1]

Image normalisation logs out an error: "the number of channels should be either 1 or 3, found 1"

@Michael-F-Bryan Michael-F-Bryan transferred this issue from hotg-ai/rune Apr 13, 2022
@Michael-F-Bryan
Copy link
Contributor

The code at fault is this match statement:

match *dimensions {
[_, _, _, 3] => {},
[_, _, _, channels] => panic!(
"The number of channels should be either 1 or 3, found {}",
channels
),
_ => panic!("The image normalization proc block only supports outputs of the form [frames, rows, columns, channels], found {:?}", dimensions),
}

The first arm needs to be changed to [_, _, _, 3] | [_, _, _, 1] => {} when we go through and migrate the image-normalization proc-block to the new Rune ABI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants