Implement automatic precompilation of the theme #656
Conversation
Following the path of Adwaita, this commit implements the automation to automatically precompile the GTK3 theme versions to gresource binary files, to improve performance of theme rendering, and avoid unnecessary re-read and re-parsing of the theme on every app run. Given that the theme is coded in sass to begin with directly altering it is not a reasonable thing to do, and so we don't loose anything by having the installed theme in binary form, specially when accessing the sources is easy enough.
Following the path of Adwaita, this commit implements the automation to automatically precompile the GTK3 theme versions to gresource binary files, to improve performance of theme rendering, and avoid unnecessary re-read and re-parsing of the theme on every app run. . Given that the theme is coded in sass to begin with directly altering it is not a reasonable thing to do, and so we don't loose anything by having the installed theme in binary form, specially when accessing the sources is easy enough. . The takes #656 and adds to this proposed commit and ensures that precompilation works for both GTK+3.18 and later GTK+ versions
|
@andresclari this appears to break Arc-Dark - any thoughts what is the issue? GTK+3.26
|
|
@fossfreedom Does this arc-design/arc-theme#19 replace this PR now? |
|
@NicoHood yes and no... so sassc enables the theme to generate the necessary CSS when building. This PR converts that CSS into the more efficient gresources format - so apps load and display faster. |
|
@fossfreedom do you have to manually generate the css or gtk+ will do it for you https://github.com/GNOME/gtk/tree/master/gtk/theme/Adwaita
|
|
In the current theme you need to use the HACKING.md instructions to generate the CSS from the .scss changes. |
|
Is the speed difference measurable? This sounds like a very good idea anyways. Lets import this issue: |
… of Adwaita, this commit implements the automation to automatically precompile the GTK3 theme versions to gresource binary files, to improve performance of theme rendering, and avoid unnecessary re-read and re-parsing of the theme on every app run. . Given that the theme is coded in sass to begin with directly altering it is not a reasonable thing to do, and so we don't loose anything by having the installed theme in binary form, specially when accessing the sources is easy enough. . The takes horst3180#656 and adds to this proposed commit and ensures that precompilation works for both GTK+3.18 and later GTK+ versions
Following the path of Adwaita, this commit implements the automation to
automatically precompile the GTK3 theme versions to gresource binary
files, to improve performance of theme rendering, and avoid unnecessary
re-read and re-parsing of the theme on every app run.
Given that the theme is coded in sass to begin with directly altering it
is not a reasonable thing to do, and so we don't loose anything by
having the installed theme in binary form, specially when accessing the
sources is easy enough.