Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use built frontend from frontend repo #132

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Use built frontend from frontend repo #132

merged 3 commits into from
Nov 21, 2024

Conversation

wendevlin
Copy link
Contributor

  • main.go
    • change static files handle
  • Frontend is built in home-assistant/frontend repo

agners
agners approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on development environment along with the DNS fallback logic.

LGTM, thanks! 🙏

@agners agners marked this pull request as draft November 21, 2024 09:18
@wendevlin wendevlin marked this pull request as ready for review November 21, 2024 10:23
@agners agners merged commit eed4d37 into home-assistant:main Nov 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agners agners agners approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendevlin @agners