Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeKit Bridge fans should not have present modes exposed as switches by default #132024

Open
timdream opened this issue Dec 1, 2024 · 2 comments

Comments

@timdream
Copy link

timdream commented Dec 1, 2024

The problem

I added a fan to Apple Home app and found the bridge grouped a few non-descriptive switches with the fan.

Upon researching, I realized this is a feature added in #45962 by @bdraco to expose all available present modes from the fan to HomeKit.

(Aside: I didn't dig deeper into why the names of the switches are non-descriptive; it seems that the code did try to make them descriptive.)

While I value @bdraco's contribution and respect his code ownership, this doesn't feel like a proper default behavior. The switches clutter the views in the Home app, and they are impossible to remove from the Room view. Also, the documentation does not explain the present modes support (and the way it supports them by exposing them as switches).

I am asking for any of the following solutions to resolve this issue:

  1. Stop exposing present modes and ask people to set up their own template switches for each of the present modes. This is the least preferable solution, since it reverts Add support for preset modes in homekit fans #45962 which had been there for three years. It may cause some surprises to people who depend on this feature.
  2. Enable some kind of entity_config allowing the switches to be not exposed. The drawback of this solution is that users will only be able to access this option when the bridge is defined in YAML, not from the UI; unless we want to invest in extra UI work to put up all the bells and whistles.
  3. If either of the solutions is preferable, at the very least, we should update the documentation and explain what these switches are. We may also explain to people who really want to remove those switches to define a template fan and expose that fan instead — the template fan is arguably more work than template switches, though, given the Helper UI is not available.

Regardless the solution chosen, I want to thank you for your attention to this issue and the contribution to Home Assistant.

What version of Home Assistant Core has the issue?

core-2024.11.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

HomeKit Bridge

Link to integration documentation on our website

https://www.home-assistant.io/integrations/homekit/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Dec 1, 2024

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


homekit documentation
homekit source
(message by IssueLinks)

@home-assistant
Copy link

home-assistant bot commented Dec 1, 2024

Hey there @PhracturedBlue, @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign template Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


template documentation
template source
(message by IssueLinks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants