Add dimming_delta support #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense to open the libraries api a bit more to support dimming_delta functionality. So I'll change the code in a more generic way like
if brightness is None we do not send any update, however this should not happen :) |
olsen-sorensen
force-pushed
the
feature/add_stop_dimming
branch
from
f7b4892
to
aad9012
Compare
olsen-sorensen
force-pushed
the
feature/add_stop_dimming
branch
2 times, most recently
from
6bab2fe
to
aa4d88b
Compare
This method sets the brightness_delta value and its action based on the value to up/down/stop. This can be useful if someone wants to dim a light to the max/min value within a dedicated transition time but stop the transition when for instance a btn was released.
olsen-sorensen
force-pushed
the
feature/add_stop_dimming
branch
from
aa4d88b
to
3e0ba79
Compare
marcelveldt
reviewed
Nov 26, 2024
| """ | ||
| if brightness_delta is not None: | ||
| update_obj = GroupedLightPut() | ||
| action = DeltaAction.DOWN if brightness_delta < 0 else DeltaAction.UP if brightness_delta > 0 else DeltaAction.STOP |
There was a problem hiding this comment.
please split this one up into a specific definition for the None case
if brightness_delta is None or brightness_delta == 0:
action = DeltaAction.STOP
elif brightness_delta < 0:
...
else:
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method sets the brightness_delta value and its action based on the
value to up/down/stop. This can be useful if someone wants to dim a light to
the max/min value within a dedicated transition time but stop the
transition when for instance a btn was released.
resolves #420