Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document angle convention in style mapping is from the horizontal #6381

Open
ahuang11 opened this issue Sep 19, 2024 · 2 comments
Open

Document angle convention in style mapping is from the horizontal #6381

ahuang11 opened this issue Sep 19, 2024 · 2 comments
Labels
good first issue An issue well suited to a new contributor type: docs Related to the documentation and examples

Comments

@ahuang11
Copy link
Collaborator

ahuang11 commented Sep 19, 2024

With all the conventions out there, I think style mapping should explicitly state it's from the horizontal, turning counterclockwise, or show the plot below.

I had to do this experiment to figure it out:

import holoviews as hv
import numpy as np

data = {
    "angle": np.arange(0, 360, 45),
    "x values": np.arange(0, 360, 45),
    "y values": np.zeros(8),
    "l values": np.zeros(8) + 1,
}

hv.Points(data, kdims=['x values','y values'] , vdims=['angle']).opts(
    angle=hv.dim('angle'), marker='dash'
) * hv.Labels(data, ['x values', 'l values'], 'angle').opts(ylim=(-0.5, 2), text_font_size='8px')
image

https://holoviews.org/user_guide/Style_Mapping.html

@ahuang11 ahuang11 added type: docs Related to the documentation and examples good first issue An issue well suited to a new contributor labels Sep 19, 2024
@ahuang11
Copy link
Collaborator Author

ahuang11 commented Sep 19, 2024

Converting it to aviation navigation from ChatGPT:
image

image

@hoxbro
Copy link
Member

hoxbro commented Sep 20, 2024

Your own experience likely gets to you here, as this is just using Cartesian coordinates.

Clarifying this is in the docs would be a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue well suited to a new contributor type: docs Related to the documentation and examples
Projects
None yet
Development

No branches or pull requests

2 participants