Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal creation support for Evmos #4055

Closed
jnaviask opened this issue May 26, 2023 · 6 comments · Fixed by #4543
Closed

Proposal creation support for Evmos #4055

jnaviask opened this issue May 26, 2023 · 6 comments · Fixed by #4543
Assignees
Labels
5 Few days task enhancement New feature or request

Comments

@jnaviask
Copy link
Collaborator

jnaviask commented May 26, 2023

Description

Per findings on #3986, we want to support proposal creation for Evmos communities. This will involve adding EvmosJs and creating another codepath for Evmos support.

Please ensure we perform proper codesplitting practices to avoid needing to download the EvmosJs bundle from the root. It should only be loaded when the user lands on a route that requires it.

Open questions:

  • Can we support voting as well as proposal creation? How much additional work is required?
  • Will we be able to support Metamask & WalletConnect as well as Keplr? Which wallets do we expect to work generally?

Acceptance Criteria

  • Can create Evmos proposals.
@jnaviask jnaviask added enhancement New feature or request 5 Few days task labels May 26, 2023
@jnaviask jnaviask added this to Cycle 4 May 26, 2023
@jnaviask jnaviask moved this to Teed Up 🏌️ in Cycle 4 May 26, 2023
@mhagel
Copy link
Contributor

mhagel commented Jun 1, 2023

  • Can we support voting as well as proposal creation? How much additional work is required?

Yes, I was looking at this as evmos TX support, which would be voting and proposal creation

  • Will we be able to support Metamask & WalletConnect as well as Keplr? Which wallets do we expect to work generally?

Still need to find out about this. Keplr for sure.

@mhagel mhagel moved this from Teed Up 🏌️ to In Progress ⛹️‍♂️ in Cycle 4 Jun 13, 2023
@CowMuon
Copy link
Contributor

CowMuon commented Jun 15, 2023

Excited to see draft PR here; do we have any updates on Keplr? @mhagel

@mhagel
Copy link
Contributor

mhagel commented Jun 15, 2023

@CowMuon EvmosJS supports Metamask and Keplr. I don't know enough about WalletConnect yet to know if it will work.

Please ensure we perform proper codesplitting practices to avoid needing to download the EvmosJs bundle from the root. It should only be loaded when the user lands on a route that requires it.

There is a quirk about EvmosJS that is annoying for us. It is not supported in yarn v1. It works with npm and yarn v2/3. I don't want to bother with upgrading yarn because that is a painful move. I prefer not to mix npm with yarn either, but that seems like the best option right now.

As far as loading on the route, the package will only be imported for ethermint cases that we choose. I don't think we can get around adding the evmosjs package to the commonwealth bundle. But this is pretty standard unless I am missing something.

Possible pivot:

I am considering looking into whether Telescope can generate the types we need instead of using evmosjs. EvmosJs includes transaction support along with typings, but I just need to see if it is any different from cosmJs under the hood. If not, we can use telescope just like we did for v1.

@mhagel
Copy link
Contributor

mhagel commented Jun 15, 2023

Came across some valuable info here

@mhagel
Copy link
Contributor

mhagel commented Jun 16, 2023

Lots of cleanup to do, but I have a POC in #4286

This does not use EvmosJS, but uses some helpers from that library.

@CowMuon
Copy link
Contributor

CowMuon commented Jun 20, 2023

This is the other story would like Ian to pair on, this one likely more actionable than other one? Will look for update.

@mhagel mhagel moved this from In Progress ⛹️‍♂️ to Teed Up 🏌️ in Cycle 4 Jun 27, 2023
@mhagel mhagel moved this from Teed Up 🏌️ to In Progress ⛹️‍♂️ in Cycle 4 Jul 3, 2023
@CowMuon CowMuon removed this from Cycle 4 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment