-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal creation support for Evmos #4055
Comments
Yes, I was looking at this as evmos TX support, which would be voting and proposal creation
Still need to find out about this. Keplr for sure. |
Excited to see draft PR here; do we have any updates on Keplr? @mhagel |
@CowMuon EvmosJS supports Metamask and Keplr. I don't know enough about WalletConnect yet to know if it will work.
There is a quirk about EvmosJS that is annoying for us. It is not supported in yarn v1. It works with npm and yarn v2/3. I don't want to bother with upgrading yarn because that is a painful move. I prefer not to mix npm with yarn either, but that seems like the best option right now. As far as loading on the route, the package will only be imported for ethermint cases that we choose. I don't think we can get around adding the evmosjs package to the commonwealth bundle. But this is pretty standard unless I am missing something. Possible pivot: I am considering looking into whether Telescope can generate the types we need instead of using evmosjs. EvmosJs includes transaction support along with typings, but I just need to see if it is any different from cosmJs under the hood. If not, we can use telescope just like we did for v1. |
Came across some valuable info here |
Lots of cleanup to do, but I have a POC in #4286 This does not use EvmosJS, but uses some helpers from that library. |
This is the other story would like Ian to pair on, this one likely more actionable than other one? Will look for update. |
Description
Per findings on #3986, we want to support proposal creation for Evmos communities. This will involve adding EvmosJs and creating another codepath for Evmos support.
Please ensure we perform proper codesplitting practices to avoid needing to download the EvmosJs bundle from the root. It should only be loaded when the user lands on a route that requires it.
Open questions:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: