Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch nginx so it does graceful shutdown on SIGTERM and fast shutdown… #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

syastrov
Copy link

@syastrov syastrov commented Aug 6, 2021

… on SIGQUIT.

Fixes #31

I tested manually that this works.

Based on #56

@syastrov
Copy link
Author

syastrov commented Nov 3, 2021

@beanieboi Any chance of merging this?

@nenadfspartans
Copy link

@beanieboi Any update on this?

@jaGarcia
Copy link

jaGarcia commented Feb 2, 2023

Running into nginx seemingly not passing the SIGTERM call to the underlying spring/java process. Any way to get this PR merged?

@tkrevh
Copy link

tkrevh commented Aug 19, 2024

Could someone please merge this?
We're using this patch (from a forked repo) on our Heroku production system for a couple of years now with great success.
Unfortunately, the forked repo only supports stack up to heroku-20.

So merge of this branch would be great. Thank you! :)

@nenadfilipovic
Copy link

Could someone please merge this? We're using this patch (from a forked repo) on our Heroku production system for a couple of years now with great success. Unfortunately, the forked repo only supports stack up to heroku-20.

So merge of this branch would be great. Thank you! :)

Hi, I am using my fork for about two years now https://github.com/nenadfilipovic/heroku-buildpack-nginx, works without issues. You can add it via https://buildpack-registry.s3.amazonaws.com/buildpacks/nenadfilipovic/heroku-buildpack-nginx.tgz inside buildpacks list or by nenadfilipovic/heroku-buildpack-nginx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graceful shutdowns
5 participants