Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No addFilter(String route, Filter f) api? #9459

Open
hrstoyanov opened this issue Nov 2, 2024 · 0 comments
Open

No addFilter(String route, Filter f) api? #9459

hrstoyanov opened this issue Nov 2, 2024 · 0 comments
Labels
4.x Version 4.x enhancement New feature or request P3 webserver

Comments

@hrstoyanov
Copy link
Contributor

Environment Details

  • Helidon Version: 4.1.3
  • Helidon SE or Helidon MP: SE
  • JDK version: 22
  • OS: MacOs

Currently, one can only add filter globally (for all routes):

HttpRouting.Builder.addFilter(Filter filter)

Why no api for adding filter for a specific route:

HttpRouting.Builder.addFilter(String path, Filter filter)

This is needed because only filters can handle with chains and thus propagate (the new) Java scoped values . Handlers can only do response.next(), which is not creating context/returns immediately.
@github-project-automation github-project-automation bot moved this to Triage in Backlog Nov 2, 2024
@barchetta barchetta added 4.x Version 4.x enhancement New feature or request webserver labels Nov 4, 2024
@barchetta barchetta moved this from Triage to Normal priority in Backlog Nov 4, 2024
@barchetta barchetta added the P3 label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x Version 4.x enhancement New feature or request P3 webserver
Projects
Backlog
Status: Normal priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hrstoyanov @barchetta