Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving numeric UIDs to Named Enums #37

Open
Meatballs1 opened this issue Mar 22, 2024 · 1 comment
Open

Resolving numeric UIDs to Named Enums #37

Meatballs1 opened this issue Mar 22, 2024 · 1 comment

Comments

@Meatballs1
Copy link
Collaborator

Meatballs1 commented Mar 22, 2024

Where values are returned as integers do we want to attempt to resolve these to the BSH.x.x.x enum values or leave that up to the end-user?

@adec
Copy link

adec commented Nov 25, 2024

The Home Connect Alt integration that I've been using previously provides the option of either providing the Raw values or using translations on the API server side - see Local vs. Server translation. However, the integration is using the public cloud APIs.

Personally I suggest we translate to the enum values and if people want to translate further locally.

So, for example, operation state the values would be "inactive", "Ready", "DelayedStart", etc based on the values downloaded in the feature mapping file and populated in devices.json. I think that is the current intended behaviour now isn't it?

 "552": {
      "name": "BSH.Common.Status.OperationState",
      "access": "read",
      "available": "true",
      "refCID": "03",
      "refDID": "80",
      "values": {
          "0": "Inactive",
          "1": "Ready",
          "2": "DelayedStart",
          "3": "Run",
          "4": "Pause",
          "5": "ActionRequired",
          "6": "Finished",
          "7": "Error",
          "8": "Aborting"
      }
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants