[Bug]: #23703 seems to have introduced a breaking change for aws_s3_bucket_replication_configuration rules

[yann-soubeyrand]

Terraform Core Version

1.3.0

AWS Provider Version

4.32.0

Affected Resource(s)

• aws_s3_bucket_replication_configuration

Expected Behavior

Already created aws_s3_bucket_replication_configuration resources should not lead to planned diff.

Actual Behavior

After upgrading Terraform AWS provider, some of our aws_s3_bucket_replication_configuration resources started showing diff during plan due to rule ordering mismatch. After some investigation, it seems that the problem has been introduced in #23703: before this change, rule was a set and the ordering of rules didn’t matter. Since this change, rule is a list and the order matters. Therefore, rules which haven’t been created in the same order as their declaration in code now lead to planned diff. The problem is that recreating rules will break the replication I guess. And changing all the resources in our code to match the actual rule order isn’t really feasible.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

A configuration with lots of aws_s3_bucket_replication_configuration resources having several rule.

Steps to Reproduce

• Have a lot of aws_s3_bucket_replication_configuration resources created with a Terraform AWS provider in version 4.3.0.
• Upgrade Terraform AWS provider to 4.32.0.
• See a lot of diff on rule ordering during terraform plan.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No response

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[yann-soubeyrand]

Link to the issue in terraform-plugin-sdk which #23703 fixed by switching from set to list for rule:
hashicorp/terraform-plugin-sdk#652.
Link to the fix for the above issue which could maybe allow reverting back to a set for rule:
hashicorp/terraform-plugin-sdk#1042.

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!