Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Update Org and Run Tasks for Private Run Tasks #944

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glennsarti
Copy link
Contributor

Description

This commit updates the Org. entitlements for the new Private Run Tasks feature. This commit also updates the Run Task options struct for CRUD operations to pass through the agent pool relationship

Testing plan

Handled by integration test changes.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

?   	github.com/hashicorp/go-tfe/examples/backing_data	[no test files]
?   	github.com/hashicorp/go-tfe/examples/configuration_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/organizations	[no test files]
?   	github.com/hashicorp/go-tfe/examples/registry_modules	[no test files]
?   	github.com/hashicorp/go-tfe/examples/run_errors	[no test files]
?   	github.com/hashicorp/go-tfe/examples/state_versions	[no test files]
?   	github.com/hashicorp/go-tfe/examples/users	[no test files]
?   	github.com/hashicorp/go-tfe/examples/workspaces	[no test files]
?   	github.com/hashicorp/go-tfe/mocks	[no test files]
=== RUN   TestRunTasksCreate
=== RUN   TestRunTasksCreate/with_an_agent_pool            <------- Test passed, not skipped
=== RUN   TestRunTasksCreate/add_run_task_to_organization
=== RUN   TestRunTasksCreate/add_run_task_to_organization/ensure_org_is_deserialized_properly
--- PASS: TestRunTasksCreate (4.56s)
    --- PASS: TestRunTasksCreate/with_an_agent_pool (0.57s)
    --- PASS: TestRunTasksCreate/add_run_task_to_organization (0.50s)
        --- PASS: TestRunTasksCreate/add_run_task_to_organization/ensure_org_is_deserialized_properly (0.00s)
=== RUN   TestRunTasksCreateWithoutGlobalEntitlement
=== RUN   TestRunTasksCreateWithoutGlobalEntitlement/add_run_task_to_organization
--- PASS: TestRunTasksCreateWithoutGlobalEntitlement (3.38s)
    --- PASS: TestRunTasksCreateWithoutGlobalEntitlement/add_run_task_to_organization (0.36s)
=== RUN   TestRunTasksList
=== RUN   TestRunTasksList/with_no_params
--- PASS: TestRunTasksList (5.87s)
    --- PASS: TestRunTasksList/with_no_params (0.40s)
=== RUN   TestRunTasksRead
=== RUN   TestRunTasksRead/by_ID
=== RUN   TestRunTasksRead/with_options
--- PASS: TestRunTasksRead (8.41s)
    --- PASS: TestRunTasksRead/by_ID (0.41s)
    --- PASS: TestRunTasksRead/with_options (3.48s)
=== RUN   TestRunTasksUpdate
=== RUN   TestRunTasksUpdate/rename_task
=== RUN   TestRunTasksUpdate/toggle_enabled
=== RUN   TestRunTasksUpdate/update_description
=== RUN   TestRunTasksUpdate/with_an_agent_pool.            <------- Test passed, not skipped
--- PASS: TestRunTasksUpdate (7.16s)
    --- PASS: TestRunTasksUpdate/rename_task (0.78s)
    --- PASS: TestRunTasksUpdate/toggle_enabled (0.80s)
    --- PASS: TestRunTasksUpdate/update_description (0.72s)
    --- PASS: TestRunTasksUpdate/with_an_agent_pool (0.56s)
=== RUN   TestRunTasksDelete
=== RUN   TestRunTasksDelete/with_valid_options
=== RUN   TestRunTasksDelete/when_the_run_task_does_not_exist
=== RUN   TestRunTasksDelete/when_the_run_task_ID_is_invalid
--- PASS: TestRunTasksDelete (4.95s)
    --- PASS: TestRunTasksDelete/with_valid_options (0.62s)
    --- PASS: TestRunTasksDelete/when_the_run_task_does_not_exist (0.30s)
    --- PASS: TestRunTasksDelete/when_the_run_task_ID_is_invalid (0.00s)
=== RUN   TestRunTasksAttachToWorkspace
=== RUN   TestRunTasksAttachToWorkspace/to_a_valid_workspace
--- PASS: TestRunTasksAttachToWorkspace (5.77s)
    --- PASS: TestRunTasksAttachToWorkspace/to_a_valid_workspace (0.71s)
=== RUN   TestRunTasksIntegration_Validate
=== RUN   TestRunTasksIntegration_Validate/with_an_empty_status
=== RUN   TestRunTasksIntegration_Validate/without_valid_Status_options
=== RUN   TestRunTasksIntegration_Validate/with_valid_Status_options
--- PASS: TestRunTasksIntegration_Validate (0.00s)
    --- PASS: TestRunTasksIntegration_Validate/with_an_empty_status (0.00s)
    --- PASS: TestRunTasksIntegration_Validate/without_valid_Status_options (0.00s)
    --- PASS: TestRunTasksIntegration_Validate/with_valid_Status_options (0.00s)
=== RUN   TestRunTasksIntegration_ValidateCallback
=== RUN   TestRunTasksIntegration_ValidateCallback/with_invalid_callbackURL
=== RUN   TestRunTasksIntegration_ValidateCallback/with_invalid_accessToken
--- PASS: TestRunTasksIntegration_ValidateCallback (0.00s)
    --- PASS: TestRunTasksIntegration_ValidateCallback/with_invalid_callbackURL (0.00s)
    --- PASS: TestRunTasksIntegration_ValidateCallback/with_invalid_accessToken (0.00s)
=== RUN   TestRunTasksIntegration_Callback
--- PASS: TestRunTasksIntegration_Callback (0.01s)
PASS
ok  	github.com/hashicorp/go-tfe	40.928s

@glennsarti glennsarti force-pushed the gs/add-private-run-tasks branch from 3ba7a80 to 5ce883c Compare August 1, 2024 02:52
@glennsarti glennsarti self-assigned this Aug 1, 2024
@glennsarti glennsarti force-pushed the gs/add-private-run-tasks branch 2 times, most recently from a43d2dd to 7bc320e Compare August 1, 2024 05:20
This commit updates the Org. entitlements for the new Private Run Tasks feature.
This commit also updates the Run Task options struct for CRUD operations to
pass through the agent pool relationship
@glennsarti glennsarti force-pushed the gs/add-private-run-tasks branch from 7bc320e to a0d0245 Compare August 5, 2024 01:13
@glennsarti glennsarti changed the title Update Org and Run Tasks for Private Run Tasks [DO NOT MERGE] Update Org and Run Tasks for Private Run Tasks Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant