Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not work on ios 12 #98

Open
ysdvincent opened this issue Sep 12, 2018 · 3 comments
Open

Not work on ios 12 #98

ysdvincent opened this issue Sep 12, 2018 · 3 comments

Comments

@ysdvincent
Copy link

No description provided.

@HiramKarim
Copy link

There some issues in the code that must be fixed ASAP:

Files:

Options.swift
Line 98

MenuContainerViewController.swift
Lines: 150 and 168

@epitonium
Copy link

I have a strange behaviour on ios 12 too. Right bar button items disappear some times and some times not.

@prasenraj
Copy link

HI @HiramKarim
MenuContainerViewController.swift
Lines: 150 and 168
you change this line like "currentContentVC.removeFromParentViewController()"
and "addChild(selectedContentVC)" to "self.addChildViewController(selectedContentVC)"

Options.swift
Line 98
public var animationOptions: UIView.AnimationOptions = .curveEaseInOut
to
public var animationOptions:UIViewAnimationOptions = .curveEaseInOut

it's working fine. Try to do changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants