You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true
You may also want to revisit other Release profile flags. I see that already was a PR about disabling LTO but this PR was 7 years ago - it's probably a good time to rethink this change.
I have made several benchmarks (env: Rustc 1.79, Fedora 40, AMD Ryzen 5900x):
Hi!
I noticed that in the
Cargo.tomlfile Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional
distorrelease-ltoprofile where additionally to regularreleaseoptimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application withcargo install, will get the LTO-optimized version "automatically". E.g., checkcargo-outdatedRelease profile.Basically, it can be enabled with the following lines:
You may also want to revisit other Release profile flags. I see that already was a PR about disabling LTO but this PR was 7 years ago - it's probably a good time to rethink this change.
I have made several benchmarks (env: Rustc 1.79, Fedora 40, AMD Ryzen 5900x):
The binary sizes (
ls -lah):Release:
Thin LTO:
Fat LTO:
Thank you.
P.S. It's more like an improvement idea rather than a bug. I created the issue just because the Discussions are disabled for the repo for now.
The text was updated successfully, but these errors were encountered: