Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Supervisor should refuse to start if it cannot bind its ports #7734

Open
christophermaier opened this issue Jun 4, 2020 · 3 comments
Open
Labels
Team:Habitat All issues tied to Chef habitat team Type: Bug Issues that describe broken functionality

Comments

@christophermaier
Copy link
Contributor

The Supervisor's various subsystems spin up on different threads at startup. However, once the threads are spawned, they no longer communicate with the main thread of the Supervisor directly. This can lead to situations where, say, some other process on the machine has already bound the incoming gossip port of the Butterfly server. This can lead to a Supervisor that appears to be running normally, but is in fact completely oblivious to gossip coming from the outside world. The thread trying to bind that port panics and dies, and will log a message saying as much. This single log message can quickly be lost in a sea of other messages, which themselves contribute to the overall appearance of a properly functioning Supervisor.

We should more closely monitor these threads as they start up and exit with an error if any of them fail. Additionally, we should also look into graceful ways of shutting down / restarting / otherwise handling crashes of such threads in an running Supervisor.

@christophermaier christophermaier added Type: Bug Issues that describe broken functionality and removed C-bug labels Jul 24, 2020
@stale
Copy link

stale bot commented Jul 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jul 26, 2021
@mwrock mwrock removed the Stale label Jul 26, 2021
@rahulgoel1 rahulgoel1 added the Team:Habitat All issues tied to Chef habitat team label Jul 30, 2021
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

1 similar comment
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Habitat All issues tied to Chef habitat team Type: Bug Issues that describe broken functionality
Projects
None yet
Development

No branches or pull requests

3 participants