Highlight incomplete dungeon bounties on the Daily Quest window

[blastedt]

I use the Daily Window highlighting for completionist purposes on ZM and ZV - this is extremely helpful.

Many of the bounties are end bosses of dungeons. It would be excellent if these bounties were highlighted if I have not completed the dungeon on that character.

Thank you for making toolbox!

[blastedt]

Trying to add the "feature request" tag but doesn't look like I have access, sorry

[blastedt]

I have extra time and this is more likely to be completed if I do some initial investigations.

The message is handled by GetIncompleteStatusMessage in DailyQuestsWindow.cpp. This is itself only called in a lambda for certain types of daily (missions and vanquishes of course). The false here would need to be changed to true to enable the check.

It looks like the core issue with using GetIncompleteStatusMessage for bounties out of the box is that it uses a gw MapID to check completion against worldcontext, and the zaishen bounties currently have no map ids in this window code. Probably the easiest way to solve this (with zero context on guild wars modding) would be to associate the dungeon bounties with map ids manually like the Nicolas cycle. Then you could check for map->type == GW::RegionType::Dungeon in GetIncompleteStatusMessage.

This is where my understanding starts to break down. I'm not sure if you can check dungeon completion in the same way as mission completion, and though CompletionWindow.cpp does successfully perform this check I'm having trouble understanding it.

[blastedt]

It looks like GWCA is getting WorldContext from a direct memory scan of the game process and I don't know if there's any documentation of that. Going to see if I can pull it from toolbox and inspect it somehow so I know what kind of check we need to perform.

edit: looks like toolbox has a debug tool for checking map info but not for world context, so I'm at a deadend unless I want to implement a worldcontext debug menu myself. Might do that tomorrow but probably not.

[blastedt]

It sure looks like, from CompletionWindow, that dungeon completion is handled the same as mission completion. A list of mapids the completion buffer in worldcontext uses for the dungeons is in CompletionWindow.cpp.

[blastedt]

Looks like this is being done in latest version of toolbox, thanks