Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing state translations #144

Closed
AverageMarcus opened this issue Jul 21, 2024 · 0 comments · Fixed by #153
Closed

Missing state translations #144

AverageMarcus opened this issue Jul 21, 2024 · 0 comments · Fixed by #153

Comments

@AverageMarcus
Copy link
Contributor

I noticed this morning that sensor.tumble_dryer_program_phase initially has a value of 1 when starting a new run, shortly followed by it moving to Drying.

It looks as though the tumbledryer_program_phase translation is missing for 1 so not providing a human-friendly display value. I was too slow to check the official app to see what it calls that phase but I suspect it's something along the lines of "Starting".

I also noticed in this issue comment that there seems to be translations missing for other devices too. I'm wondering if it would be helpful to track the ones that are missing so people with those devices can contribute what the numbers relate to in the official app.

Additionally, I wonder if it would be useful to have a "fallback" value of "Unknown State" or something when a translation doesn't exist so that users aren't just presented with the confusing number?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant