Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Bypass Baysor patches where no cells #150

Open
lguerard opened this issue Nov 4, 2024 · 4 comments
Open

[Feature] Bypass Baysor patches where no cells #150

lguerard opened this issue Nov 4, 2024 · 4 comments

Comments

@lguerard
Copy link
Contributor

lguerard commented Nov 4, 2024

Is your feature request related to a problem? Please describe.
When running sopa using snakemake, everything runs fine until some Baysor patches fail due to not enough cells pass prior min_mol_per_cell. This can definitely happen if some patches are outside the sample or low transcripts in specific regions. However, this then blocks the pipeline from continuing.

Describe the solution you'd like
The API has the possibility to get the valid_indices for the patches to continue, is there any way of using that for snakemake as well ?

Describe alternatives you've considered
If this is not possible, would it be possible to move out/rename these patches and continue with the pipeline ?

Thanks a lot for your help !

@quentinblampey
Copy link
Collaborator

Hi @lguerard,

Actually, the snakemake pipeline is already using the valid_indices. But it's difficult to check whether Baysor will succeed or not, and currently we decide to keep a patch if there are more than 4000 transcripts in that patch.

In sopa==2.0.0, there will be an API argument to continue running baysor even when this happen (force argument), I'll let you know when it's released!

@lguerard
Copy link
Contributor Author

lguerard commented Nov 4, 2024

Thanks for the (very !) fast answer !

So the slurm job exits with an error which then stops the whole pipeline, is that expected ? It also doesn't resolve if you rerunning it as it's looking for the loom files (makes sense as it doesn't have the valid_indices anymore.

@quentinblampey
Copy link
Collaborator

Normally, 4000 transcripts should be enough for Baysor, but sometimes, there can still be an error. Indeed, in that case, the pipeline stops, and you'll not be able to finish running it except if you remove the index of the patch from the valid_indices file from the cache (which is quite painful to do).

So hopefully, the force argument from the API will help, I'll let you know :)

@lguerard
Copy link
Contributor Author

lguerard commented Nov 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants