Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging improvements #335

Conversation

jmahlik
Copy link
Contributor

@jmahlik jmahlik commented Oct 10, 2024

General packaging improvements. Happy to adjust as needed, just let me know :).

It might be time to consider dropping support/testing for python 3.7 and 3.8. They are both end of life and the CI might not be able to run against them. I'm unsure if some of the C extension dependencies will install on them. Possibly old versions of the packages.

The main reason for the PR:

<string>:7: SetuptoolsDeprecationWarning: The test command is disabled and references to it are deprecated.
!!

        ********************************************************************************
        Please remove any references to `setuptools.command.test` in all supported versions of the affected package.

        By 2024-Nov-15, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.
        ********************************************************************************

!!
C:\Users\rm13\AppData\Local\Temp\build-env-i_ls03r0\Lib\site-packages\setuptools\_distutils\dist.py:261: UserWarning: Unknown distribution option: 'tests_require'

Has been deprecated for 5+ years and has been removed in recent
setuptools versions.

See pypa/setuptools#4519
Remove `tests_require`, it is essentially deprecated and wasn't used.

See pypa/setuptools#931, it's likely to be
removed soon.
@guillermo-navas-palencia
Copy link
Owner

Thanks @jmahlik. I know that many users still use Python 3.7 and 3.8 (especially), so I would keep the support for some time. See pystats: https://pypistats.org/packages/optbinning. I agree that removing test command is a good idea.

@guillermo-navas-palencia guillermo-navas-palencia merged commit 6773258 into guillermo-navas-palencia:develop Oct 14, 2024
@jmahlik jmahlik deleted the packaging-improvements branch October 14, 2024 21:06
@guillermo-navas-palencia guillermo-navas-palencia mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants