Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBounds for is_run_visible is clamped to be the same as the viewport resolution #124

Open
jose-acevedoflores opened this issue Dec 10, 2024 · 0 comments

Comments

@jose-acevedoflores
Copy link

#110 changed the criteria for determining what is visible compared to the original method in #108.
From start_y <= text_area.bounds.bottom && text_area.bounds.top <= end_y
To start_y <= bounds_max_y && bounds_min_y <= end_y
and the bounds_max//min is clamped.

My case uses a TextBound that is bigger than the resolution so I can shift my TextArea beyond what is visible.

I'm wondering if that change in #110 to use the clamped bounds is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant