Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Refactor deprecate-vts standalone tool #760

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

amy-gb
Copy link
Contributor

@amy-gb amy-gb commented Oct 9, 2024

What

Small updates to the deprecate-vts tool, based on my usage over the past few months.

  • Added the --from-file option to process a list of filepaths (same as the last-modification tool)
  • Removed the option to pass multiple files in the --files arg, this is only used for a single file now
  • Removed the option to deprecate based on a filename prefix, as this was a one-time use case and hasn't come up again

Why

General refactors to improve workflow

Checklist

  • Tests
  • tested all args locally

@amy-gb amy-gb requested a review from a team as a code owner October 9, 2024 09:09
Copy link

github-actions bot commented Oct 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA e62d7ce.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Oct 9, 2024

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@amy-gb amy-gb force-pushed the deprecate-vts-update branch from d74704b to 8eb0e6d Compare October 9, 2024 09:11
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (ae1553b) to head (e62d7ce).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
troubadix/standalone_plugins/deprecate_vts.py 36.36% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   79.79%   79.57%   -0.23%     
==========================================
  Files          87       87              
  Lines        2974     2986      +12     
  Branches      639      642       +3     
==========================================
+ Hits         2373     2376       +3     
- Misses        454      462       +8     
- Partials      147      148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amy-gb amy-gb force-pushed the deprecate-vts-update branch from 8eb0e6d to e62d7ce Compare October 9, 2024 09:14
Copy link
Member

@n-thumann n-thumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amy-gb amy-gb merged commit 9bdfc5a into main Oct 11, 2024
11 of 13 checks passed
@amy-gb amy-gb deleted the deprecate-vts-update branch October 11, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants