add: allow reading secrets from files #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Instead of supplying the secret via env var SECRET they can be also passed via env var SECRET_FILE. The secret is then read from the given file path. If the same secret is supplied in both ways, the value passed directly by env var takes precedence
mgoetzegb
force-pushed
the
secrets-from-files
branch
from
796ab7a
to
b005aea
Compare
|
added explaining comment to config and missing trailing newline to compose file |
llugin
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow reading secrets from files.
Pass the path to the file containing the secret to the service by appending
_FILEto the env var name which normally would contain the secret directly.If both env vars
SECRETandSECRET_FILEare set,SECRETtakes precedence.As the original way of supplying secrets is still supported, this is a backwards compatible change.
Why
Using the docker secrets feature results in files containing the secret being placed into the container filesystem.
References
VTI-300
Checklist