Change: Replace CPE xml_split with XML iterator #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating the CPEs, the CPE dictionary file is no longer split into separate temporary files. Instead a new XML file iterator added to gvm-libs is used to avoid creating the DOM of the whole file. Also, the buffered insert statements are now also run when a size threshold configurable via a setting is reached. This removes the dependency on the xml_split script, avoids problems with the temp split XML files being left behind in case of crashes and gives more control over the memory usage of the CPEs update.
Conventional Commits Report
🚀 Conventional commits found. |
The error handling is improved by freeing the iterator on errors, consistently jumping to the failure handling and handling cases where (re-)initalizing the parser context fails. Also the limit for the threshold is now always applied.
a-h-abdelsalam
previously approved these changes
Mar 5, 2024
cfi-gb
suggested changes
Mar 6, 2024
This optional dependency is no longer needed with the new XML file iterator.
No, you're right. I've removed these references now. |
a-h-abdelsalam
approved these changes
Mar 6, 2024
|
Only for references, this could possibly also solves problems from the past like e.g.: |
This was referenced Nov 13, 2024
|
It seems two additional places have been missed (A comment in the Dockerfile and the community docs) which have been adjusted now accordingly: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When updating the CPEs, the CPE dictionary file is no longer split into separate temporary files. Instead a new XML file iterator added to gvm-libs is used to avoid creating the DOM of the whole file. Also, the buffered insert statements are now also run when a size threshold configurable via a setting is reached.
Why
This removes the dependency on the xml_split script, avoids problems with the temp split XML files being left behind in case of crashes and gives more control over the memory usage of the CPEs update.
References
requires greenbone/gvm-libs#808
GEA-488