Merge pull request #2327 from greenbone/fix-create-credential-privkey…

…-error Fix: Rollback on create_credential privkey error
greenbone · Dec 2, 2024 · 71f7362 · 71f7362
2 parents 2d79e64 + e2ca261
commit 71f7362
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/manage_sql.c b/src/manage_sql.c
@@ -35785,6 +35785,7 @@ create_credential (const char* name, const char* comment, const char* login,
   else
     {
       g_warning ("%s: Cannot determine type of new credential", __func__);
+      sql_rollback ();
       return 18;
     }
 
@@ -35952,7 +35953,10 @@ create_credential (const char* name, const char* comment, const char* login,
       if (key_private)
         key_private_truncated = truncate_private_key (key_private);
       else
-        return 3;
+        {
+          sql_rollback ();
+          return 3;
+        }
 
       generated_key_public = gvm_ssh_public_from_private
                                 (key_private_truncated
@@ -35962,6 +35966,7 @@ create_credential (const char* name, const char* comment, const char* login,
       if (generated_key_public == NULL)
         {
           g_free (key_private_truncated);
+          sql_rollback ();
           return 3;
         }
       g_free (generated_key_public);