Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update subgraphs to use id on encoder #24

Merged
merged 2 commits into from
Jun 14, 2024
Merged

chore: update subgraphs to use id on encoder #24

merged 2 commits into from
Jun 14, 2024

Conversation

Maikol
Copy link
Member

@Maikol Maikol commented May 31, 2024

No description provided.

tmigone
tmigone reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use "subgraph deployment id" instead of "subgraph id" to be more specific. Perhaps that's what you were thinking but I would make it explicit.

json-encoder-web/index.ts Outdated Show resolved Hide resolved
@Maikol Maikol requested a review from tmigone June 13, 2024 21:17
@Maikol Maikol merged commit 61f6aa6 into main Jun 14, 2024
4 checks passed
@Maikol Maikol deleted the mde/update-json-encoder-web branch June 14, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigone tmigone tmigone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maikol @tmigone